Fix #170

Author: okken

changelog.md

@@ -19,6 +19,12 @@ All notable changes to this project  be documented in this file.
 - nothing so far
 
 -->
+## [2.5.2] - 2025-Mar-29
+
+### Fixed
+
+- Fixes a weird corner case where an internal error could be generated by (1) having a session scope fixture fail in teardown and (2) having the last test in the session be skipped. Thanks @asyash26 for reporting and creating reproduction steps. Resolves #170
+
 ## [2.5.1] - 2025-Mar-18
 
 ### Fixed

examples/test_example_fail_in_teardown_with_skip.py

@@ -0,0 +1,26 @@
+"""
+Ensure that failing in teardown works.
+
+There's something about this order that can trip up the plugin.
+
+1. A session scope fixture fails in teardown with pytest_check.fail()
+2. The last test of the session is skipped.
+
+This is what's happening in issue #170
+Causing a fix in pytest-check 2.5.2
+"""
+
+import pytest
+from pytest_check import check
+
+@pytest.fixture(scope="session")
+def fail_in_teardown():
+    yield
+    check.fail("Failed in teardown")
+
+def test_fail_in_teardown(fail_in_teardown):
+    assert 1 == 1  
+
+@pytest.mark.skip
+def test_skip():
+    assert 1 == 1  

pyproject.toml

@@ -4,7 +4,7 @@ authors = [{name = "Brian Okken"}]
 readme = "README.md"
 license = {file = "LICENSE.txt"}
 description="A pytest plugin that allows multiple failures per test."
-version = "2.5.1"
+version = "2.5.2"
 requires-python = ">=3.9"
 classifiers = [
     "License :: OSI Approved :: MIT License",

src/pytest_check/__init__.py

@@ -1,8 +1,9 @@
 import pytest
-from . import check_functions
 
-# make sure assert rewriting happens
-pytest.register_assert_rewrite("pytest_check.check_functions")
+# We need register rewrites before import
+pytest.register_assert_rewrite("pytest_check.check_functions") 
+
+from . import check_functions # noqa: E402
 
 # allow for top level helper function access:
 # import pytest_check

src/pytest_check/plugin.py

@@ -30,12 +30,11 @@ def pytest_runtest_makereport(
     check_log.clear_failures()
 
     if failures:
-        xfailed_value = item._store[xfailed_key]
+        xfailed_value = item._store.get(xfailed_key, None)
         if xfailed_value and not item.config.option.runxfail:
             report.outcome = "skipped"
             report.wasxfail = xfailed_value.reason
         else:
-
             summary = f"Failed Checks: {num_failures}"
             longrepr = ["\n".join(failures)]
             longrepr.append("-" * 60)

tests/test_fail_in_teardown_with_skip.py

@@ -0,0 +1,4 @@
+def test_skip_teardown_fail(pytester):
+    pytester.copy_example("examples/test_example_fail_in_teardown_with_skip.py")
+    result = pytester.runpytest()
+    result.assert_outcomes(passed=1, skipped=1, errors=1)