Skip to content

Commit 05d73eb

Browse files
committed
Add audit of no permissions
1 parent 0299bb2 commit 05d73eb

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

sonar/applications.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,12 @@ def audit(self, audit_settings: types.ConfigSettings) -> list[problem.Problem]:
321321
:rtype: list [Problem]
322322
"""
323323
log.info("Auditing %s", str(self))
324-
return self._audit_empty(audit_settings) + self._audit_singleton(audit_settings) + self._audit_bg_task(audit_settings)
324+
return (
325+
super().audit(audit_settings)
326+
+ self._audit_empty(audit_settings)
327+
+ self._audit_singleton(audit_settings)
328+
+ self._audit_bg_task(audit_settings)
329+
)
325330

326331
def export(self, export_settings: types.ConfigSettings) -> types.ObjectJsonRepr:
327332
"""Exports an application
@@ -346,7 +351,7 @@ def export(self, export_settings: types.ConfigSettings) -> types.ObjectJsonRepr:
346351
)
347352
return util.remove_nones(util.filter_export(json_data, _IMPORTABLE_PROPERTIES, export_settings.get("FULL_EXPORT", False)))
348353

349-
def set_permissions(self, data):
354+
def set_permissions(self, data: types.JsonPermissions) -> application_permissions.ApplicationPermissions:
350355
"""Sets an application permissions
351356
352357
:param dict data: dict of permission {"users": [<user1>, <user2>, ...], "groups": [<group1>, <group2>, ...]}

sonar/portfolios.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,12 @@ def _audit_singleton(self, audit_settings: types.ConfigSettings) -> list[problem
331331
def audit(self, audit_settings: types.ConfigSettings) -> list[problem.Problem]:
332332
"""Audits a portfolio"""
333333
log.info("Auditing %s", str(self))
334-
return self._audit_empty(audit_settings) + self._audit_singleton(audit_settings) + self._audit_bg_task(audit_settings)
334+
return (
335+
super().audit(audit_settings)
336+
+ self._audit_empty(audit_settings)
337+
+ self._audit_singleton(audit_settings)
338+
+ self._audit_bg_task(audit_settings)
339+
)
335340

336341
def to_json(self, export_settings: types.ConfigSettings) -> types.ObjectJsonRepr:
337342
"""Returns the portfolio representation as JSON"""

0 commit comments

Comments
 (0)