Quality pass

Author: okorach

sonar/platform.py

@@ -823,6 +823,7 @@ def _check_for_retry(response: requests.models.Response) -> tuple[bool, str]:
 
 
 def convert_for_yaml(original_json: types.ObjectJsonRepr) -> types.ObjectJsonRepr:
+    """Convert the original JSON defined for JSON export into a JSON format more adapted for YAML export"""
     if "languages" in original_json:
         original_json["languages"] = util.dict_to_list(original_json["languages"], "language")
     if "permissions" in original_json:

sonar/qualityprofiles.py

@@ -365,7 +365,6 @@ def _treat_modified_rules(self, modified_rules: dict[str:str]) -> dict[str:str]:
         my_rules = self.rules()
         for r in modified_rules:
             r_key, r_left, r_right = r["key"], r["left"], r["right"]
-            # diff_rules[r_key] = {"modified": True}
             diff_rules[r_key] = {}
             parms = None
             if r_left["severity"] != r_right["severity"]:

sonar/rules.py

@@ -369,12 +369,6 @@ def convert_for_export(rule: types.ObjectJsonRepr, qp_lang: str, with_template_k
 def convert_rule_list_for_yaml(rule_list: types.ObjectJsonRepr) -> list[types.ObjectJsonRepr]:
     """Converts a rule dict (key: data) from a dict to a list ["key": key, **data]"""
     return utilities.dict_to_list(rule_list, "key", "severity")
-    for k, v in rule_list.items():
-        if isinstance(v, dict):
-            converted_list.append({"key": k, **v})
-        else:
-            converted_list.append({"key": k, "severity": v})
-    return converted_list
 
 
 def convert_for_yaml(original_json: types.ObjectJsonRepr) -> types.ObjectJsonRepr: