Quality pass

Author: okorach-sonar

sonar/portfolios.py

@@ -369,8 +369,8 @@ def to_json(self, export_settings: types.ConfigSettings) -> types.ObjectJsonRepr
         subportfolios = self.sub_portfolios()
         if not self.is_sub_portfolio():
             json_data["visibility"] = self._visibility
-            if perms := self.permissions().export(export_settings=export_settings):
-                json_data["permissions"] = util.perms_to_list(perms)
+            if pf_perms := self.permissions().export(export_settings=export_settings):
+                json_data["permissions"] = util.perms_to_list(pf_perms)
         json_data["tags"] = self._tags
         if subportfolios:
             json_data["portfolios"] = {}

sonar/users.py

@@ -572,6 +572,7 @@ def exists(endpoint: pf.Platform, login: str) -> bool:
 
 
 def convert_user_json(old_json: dict[str, Any]) -> dict[str, Any]:
+    """Converts a user JSON from old to new format"""
     for k in "groups", "scmAccounts":
         if k in old_json:
             old_json[k] = util.csv_to_list(old_json[k])

sonar/util/common_json_helper.py

@@ -25,6 +25,7 @@
 
 
 def convert_common_fields(json_data: dict[str, Any], with_permissions: bool = True) -> dict[str, Any]:
+    """Converts Sonar objects common fields from old to new JSON format"""
     if "permissions" in json_data and json_data["permissions"] is None:
         json_data.pop("permissions")
     if with_permissions and "permissions" in json_data:

sonar/util/platform_helper.py

@@ -48,6 +48,7 @@ def convert_basics_json(old_json: dict[str, Any]) -> dict[str, Any]:
 
 
 def convert_template_json(json_data: dict[str, Any], full: bool = False) -> dict[str, Any]:
+    """Converts a Perm Template JSON from old to new format"""
     json_data = common_json_helper.convert_common_fields(json_data)
     return util.remove_nones(util.filter_export(json_data, _PERM_TPL_IMPORTABLE_PROPERTIES, full))