Quality pass

Author: okorach-sonar

sonar/platform.py

@@ -305,7 +305,7 @@ def __run_request(self, request: callable, api: str, params: types.ApiParams = N
             if any(msg in err_msg_lower for msg in ("insufficient privileges", "insufficient permissions")):
                 raise exceptions.SonarException(err_msg, errcodes.SONAR_API_AUTHORIZATION) from e
             if "unknown url" in err_msg_lower:
-                raise exceptions.UnsupportedOperation(err_msg)
+                raise exceptions.UnsupportedOperation(err_msg) from e
             raise exceptions.SonarException(err_msg, errcodes.SONAR_API) from e
         except ConnectionError as e:
             util.handle_error(e, "")

sonar/projects.py

@@ -838,7 +838,7 @@ def count_third_party_issues(self, filters: Optional[dict[str, str]] = None) ->
             return super().count_third_party_issues(filters)
         log.debug("Getting 3rd party issues on branches/PR")
         issue_counts = {}
-        for comp in [c for c in branches_or_prs.values() if c]:
+        for comp in [co for co in branches_or_prs.values() if co]:
             log.debug("Getting 3rd party issues for %s", str(comp))
             for k, total in comp.count_third_party_issues(filters).items():
                 if k not in issue_counts:

sonar/util/cache.py

@@ -41,6 +41,7 @@ def __str__(self) -> str:
         return "'undefined class' cache" if not self.object_class else f"'{self.object_class.__name__}' cache"
 
     def set_class(self, object_class: object) -> None:
+        """Defines the class the cache is for"""
         self.object_class = object_class
 
     def contents(self) -> str:

sonar/utilities.py

@@ -822,4 +822,4 @@ def similar_strings(key1: str, key2: str, max_distance: int = 5) -> bool:
     if key1 == key2:
         return False
     max_distance = min(len(key1) // 2, len(key2) // 2, max_distance)
-    return len(key2) >= 7 and (re.match(key2, key1)) or Levenshtein.distance(key1, key2, score_cutoff=6) <= max_distance
+    return (len(key2) >= 7 and (re.match(key2, key1))) or Levenshtein.distance(key1, key2, score_cutoff=6) <= max_distance