Begin adopting SwiftTesting to improve test and runtime stability

This includes the use Swift6 toolchain for Swift 5 testing, and dropping support for Xcode 15.4.  This is acceptable because Xcode 15 is no longer supported by Apple, therefore it is no longer supported by us.

Author: AlexNachbaur

.github/actions/setup-swift/action.yaml

@@ -25,6 +25,17 @@ runs:
             echo "Using Xcode ${xcode_version} for Swift ${{ inputs.swift-version }}"
             echo "DEVELOPER_DIR=${developer_dir}" >> $GITHUB_ENV
             echo "developer_dir=${developer_dir}" >> $GITHUB_OUTPUT
+
+            swift_arguments=$(yq ".swift[] | select(.version == \"${{inputs.swift-version}}\") | .swift_arguments" "${{inputs.version-manifest}}")
+            if [[ -n "$swift_arguments" ]]; then
+              echo "Requires the use of \"${swift_arguments}\" Swift arguments"
+              echo "SWIFT_ARGUMENTS=${swift_arguments}" >> $GITHUB_ENV
+              echo "swift_arguments=${swift_arguments}" >> $GITHUB_OUTPUT
+            else
+              echo "SWIFT_ARGUMENTS=" >> $GITHUB_ENV
+              echo "swift_arguments=" >> $GITHUB_OUTPUT
+            fi
+
             exit 0
           fi
         done

.github/actions/setup-swift/versions.yaml

@@ -1,7 +1,9 @@
 swift:
+  # Swift 5.10 mode within the 6.x toolchain, since Xcode 15.4 is no longer supported by Apple on the App Store
   - version: "5.10"
+    swift_arguments: "-Xswiftc -swift-version -Xswiftc 5"
     xcode_versions: 
-      - "15.4"
+      - "16.0"
   - version: "6.0"
     xcode_versions: 
       - "16.0"

.github/workflows/documentation-ghpages.yaml

@@ -49,9 +49,7 @@ jobs:
             --output-path "docs/$VERSION" \
             --include-extended-types \
             --symbol-graph-minimum-access-level public \
-            --experimental-skip-synthesized-symbols \
             --enable-experimental-combined-documentation \
-            --enable-experimental-mentioned-in \
             --enable-experimental-external-link-support \
             --enable-experimental-overloaded-symbol-presentation \
             $TARGET_LIST

.github/workflows/tests.yaml

@@ -180,7 +180,7 @@ jobs:
       matrix:
         include:
         - swift_version: "5.10"
-          os: macos-14
+          os: macos-15
         - swift_version: "6.0"
           os: macos-15
         - swift_version: "6.1"
@@ -204,11 +204,11 @@ jobs:
     - name: Build
       run: |
         set -o pipefail
-        swift build --build-tests --verbose 2>&1 | tee -a .build/ci-logs/${LOG_NAME}-build.log | xcbeautify $XCBEAUTIFY_ARGS
+        swift build --build-tests $SWIFT_ARGUMENTS --verbose 2>&1 | tee -a .build/ci-logs/${LOG_NAME}-build.log | xcbeautify $XCBEAUTIFY_ARGS
     - name: Test
       run: |
         set -o pipefail
-        swift test --verbose 2>&1 | tee -a .build/ci-logs/${LOG_NAME}-test.log | xcbeautify $XCBEAUTIFY_ARGS
+        swift test $SWIFT_ARGUMENTS --verbose 2>&1 | tee -a .build/ci-logs/${LOG_NAME}-test.log | xcbeautify $XCBEAUTIFY_ARGS
     - name: Upload Logs
       if: failure()
       uses: actions/upload-artifact@v4

.spi.yml

@@ -8,7 +8,4 @@ builder:
         - OktaIdxAuth
         - BrowserSignin
       custom_documentation_parameters:
-        - "--enable-experimental-combined-documentation"
-        - "--enable-experimental-mentioned-in"
-        - "--experimental-skip-synthesized-symbols"
         - "--enable-experimental-external-link-support"

.swift-format

@@ -2,6 +2,7 @@
   "fileScopedDeclarationPrivacy" : {
     "accessLevel" : "private"
   },
+  "indentBlankLines": false,
   "indentConditionalCompilationBlocks" : true,
   "indentSwitchCaseLabels" : false,
   "indentation" : {

Package.swift

@@ -95,7 +95,7 @@ var package = Package(
                     resources: [.copy("MockResponses")],
                     swiftSettings: .testTarget),
     ],
-    swiftLanguageModes: [.v6]
+    swiftLanguageModes: [.v6, .v5]
 )
 
 #if canImport(UIKit) || canImport(AppKit)

Package@swift-5.10.swift

@@ -10,6 +10,7 @@ extension Array<SwiftSetting> {
         [
             .enableUpcomingFeature("ExistentialAny"),
             .enableUpcomingFeature("ForwardTrailingClosures"),
+            .enableExperimentalFeature("SwiftTesting"),
         ]
     }
 

Sources/AuthFoundation/JWT/Internal/DefaultJWKValidator.swift

@@ -13,13 +13,13 @@
 import Foundation
 
 struct DefaultJWKValidator: JWKValidator {
-    func validate(token: JWT, using keySet: JWKS) throws -> Bool {
+    func validate(token: JWT, using keySet: JWKS) throws {
         guard let key = keySet[token.header.keyId] else {
             throw JWTError.invalidKey
         }
 
         #if canImport(CommonCrypto)
-        return try key.verify(token: token)
+        try key.verify(token: token)
         #else
         throw JWTError.signatureVerificationUnavailable
         #endif

Sources/AuthFoundation/JWT/Internal/JWK+Extensions.swift

@@ -87,11 +87,13 @@ extension JWK {
                                                                attributes as NSDictionary,
                                                                &errorRef)
             else {
-                let error = errorRef?.takeRetainedValue()
-                let desc = error != nil ? CFErrorCopyDescription(error) : nil
-                let code = error != nil ? CFErrorGetCode(error) : 0
-                throw JWTError.cannotCreateKey(code: OSStatus(code),
-                                               description: desc as String?)
+                if let error = errorRef?.takeRetainedValue() {
+                    let desc = CFErrorCopyDescription(error)
+                    throw JWTError.cannotCreateKey(code: OSStatus(CFErrorGetCode(error)),
+                                                   description: desc as String?)
+                } else {
+                    throw JWTError.cannotCreateKey(code: 0, description: nil)
+                }
             }
 
             return publicKey
@@ -110,7 +112,7 @@ extension JWK {
             let addStatus = SecItemAdd(addAttributes as CFDictionary, persistKey)
             guard addStatus == errSecSuccess || addStatus == errSecDuplicateItem else {
                 throw JWTError.cannotCreateKey(code: addStatus,
-                                                        description: nil)
+                                               description: nil)
             }
 
             let copyAttributes: [CFString: Any] = [
@@ -126,7 +128,7 @@ extension JWK {
 
             guard let publicKey = keyRef else {
                 throw JWTError.cannotCreateKey(code: copyStatus,
-                                                        description: nil)
+                                               description: nil)
             }
 
             // swiftlint:disable force_cast