Merge pull request #316 from okta/jn-fix-long-running-crash

Fix long running network requests causing a crash.

Author: JayNewstrom

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 1.2.5
+
+### Bug Fix
+- [#316](https://github.com/okta/okta-oidc-android/pull/316) Fix a crash during login/logout.
+
 # 1.2.4
 
 ### Bug Fix

README.md

@@ -59,7 +59,7 @@ It is recommended that your app extends [FragmentActivity][fragment-activity] or
 Add the `Okta OIDC` dependency to your `build.gradle` file:
 
 ```gradle
-implementation 'com.okta.android:okta-oidc-android:1.2.4'
+implementation 'com.okta.android:okta-oidc-android:1.2.5'
 ```
 
 The SDK requires Java 8 support.

build.gradle

@@ -35,7 +35,7 @@ subprojects {
 
 ext {
     versionNum = 19
-    versionName = "1.2.4"
+    versionName = "1.2.5"
     versionDate = new Date()
     minSdkVersion = 21
     compileSdkVersion = 30

library/src/main/java/com/okta/oidc/OktaResultFragment.java

@@ -60,11 +60,9 @@ public static void addLogoutFragment(WebRequest request,
         fragment.logoutIntent = createAuthIntent(activity, request.toUri(), customTabOptions,
                 browsers);
         FragmentManager fragmentManager = activity.getSupportFragmentManager();
-        if (!fragmentManager.isDestroyed()) {
-            fragmentManager.beginTransaction()
-                           .add(fragment, AUTHENTICATION_REQUEST)
-                           .commit();
-        }
+        fragmentManager.beginTransaction()
+                       .add(fragment, AUTHENTICATION_REQUEST)
+                       .commit();
     }
 
     @Override

library/src/main/java/com/okta/oidc/clients/web/SyncWebAuthClientImpl.java

@@ -32,6 +32,7 @@
 import androidx.annotation.VisibleForTesting;
 import androidx.annotation.WorkerThread;
 import androidx.fragment.app.FragmentActivity;
+import androidx.lifecycle.Lifecycle;
 
 import com.okta.oidc.AuthenticationPayload;
 import com.okta.oidc.AuthenticationResultHandler;
@@ -184,6 +185,11 @@ private StateResult startSignIn(Activity activity, WebRequest request)
         CountDownLatch latch = new CountDownLatch(1);
 
         if (activity instanceof FragmentActivity) {
+            if (!((FragmentActivity) activity).getLifecycle().getCurrentState()
+                    .isAtLeast(Lifecycle.State.RESUMED)) {
+                resetCurrentState();
+                return StateResult.canceled();
+            }
             activity.runOnUiThread(() -> addLoginFragment(
                 request,
                 mCustomTabOptions,
@@ -318,6 +324,11 @@ private StateResult startSignOut(Activity activity, WebRequest request)
         CountDownLatch latch = new CountDownLatch(1);
         AtomicReference<StateResult> resultWrapper = new AtomicReference<>();
         if (activity instanceof FragmentActivity) {
+            if (!((FragmentActivity) activity).getLifecycle().getCurrentState()
+                    .isAtLeast(Lifecycle.State.RESUMED)) {
+                resetCurrentState();
+                return StateResult.canceled();
+            }
             activity.runOnUiThread(() -> addLogoutFragment(
                 request,
                 mCustomTabOptions,