Deprecate clear method (#309)

Author: oleggnidets-okta

.travis.yml

@@ -1,6 +1,6 @@
 language: objective-c
 os: osx
-osx_image: xcode12.2
+osx_image: xcode12.5
 
 before_install:
   - gem install xcpretty
@@ -36,15 +36,12 @@ jobs:
       name: CocoaPods
       script:
       - pod lib lint --allow-warnings
-    - stage: Dependency Manager Validation
-      name: Carthage
-      addons:
-        homebrew:
-          packages:
-          - carthage
-          update: true
-      script:
-      # Test two workarounds 
-      # https://github.com/Carthage/Carthage#getting-started
-      - ./scripts/carthage-xcode-12.sh build --no-skip-current
-      - carthage build --use-xcframeworks --no-skip-current
+    # - stage: Dependency Manager Validation
+    #   name: Carthage
+    #   addons:
+    #     homebrew:
+    #       packages:
+    #       - carthage
+    #       update: true
+    #   script:
+    #   - carthage build --use-xcframeworks --no-skip-current

Example/ViewController.swift

@@ -29,7 +29,6 @@ final class ViewController: UIViewController {
     private var oktaAppAuth: OktaOidc?
     private var authStateManager: OktaOidcStateManager? {
         didSet {
-            oldValue?.clear()
             authStateManager?.writeToSecureStorage()
         }
     }
@@ -95,7 +94,6 @@ final class ViewController: UIViewController {
     }
 
     @IBAction func clearTokens(_ sender: Any) {
-        authStateManager?.clear()
         try? authStateManager?.removeFromSecureStorage()
         authStateManager = nil
 

README.md

@@ -446,7 +446,9 @@ Sample app [example](https://github.com/okta/samples-ios/blob/master/browser-sig
 #### clear
 
 Removes the local authentication state by removing cached tokens in the keychain.
-**Note:** SDK deletes all keychain items accessible to an application.
+
+
+**Warning:** SDK deletes all keychain items accessible to an application.
 
 ```swift
 stateManager.clear()

Sources/OktaOidc/Common/OktaOidcStateManager.swift

@@ -158,6 +158,7 @@ open class OktaOidcStateManager: NSObject, NSSecureCoding {
         try OktaOidcKeychain.remove(key: self.clientId)
     }
 
+    @available(*, deprecated, message: "This method deletes all keychain items accessible to an application. Use `removeFromSecureStorage` to remove Okta items.")
     @objc public func clear() {
         OktaOidcKeychain.clearAll()
     }

Tests/OktaOidcTests/OktaOidcStateManagerTests.swift

@@ -370,8 +370,7 @@ class OktaOidcStateManagerTests: XCTestCase {
             storedManager?.authState.lastAuthorizationResponse.idToken,
             manager.authState.lastAuthorizationResponse.idToken
         )
-        
-        manager.clear()
+
         XCTAssertNil(OktaOidcStateManager.readFromSecureStorage(for: config))
     }
     #endif