fix: add required type for AppConfig (#583)

Author: pranav-okta

.generator/okta-management-APIs-oasv3-noEnums-inheritance.yaml

@@ -30023,6 +30023,8 @@ components:
         type:
           type: string
           $ref: '#/components/schemas/AppConfigType'
+      required:
+        - type
       discriminator:
         propertyName: type
         mapping:

CHANGELOG.md

@@ -1,6 +1,9 @@
 # Changelog
 Running changelog of releases since `2.0.0-rc.4`
 
+## v6.1.2
+- Fix AppConfig by adding required type param. Thanks [@pranav-okta](https://github.com/pranav-okta)
+
 ## v6.1.1
 - Fix ListPolicies 200 response. Thanks [@pranav-okta](https://github.com/pranav-okta)
 

okta/README.md

@@ -6,7 +6,7 @@ Allows customers to easily access the Okta Management APIs
 This API client was generated by the [OpenAPI Generator](https://openapi-generator.tech) project.  By using the [OpenAPI-spec](https://www.openapis.org/) from a remote server, you can easily generate an API client.
 
 - API version: 5.1.0
-- Package version: 6.1.1
+- Package version: 6.1.2
 - Build package: org.openapitools.codegen.languages.GoClientCodegen
 For more information, please visit [https://developer.okta.com/](https://developer.okta.com/)
 

okta/api/openapi.yaml

@@ -48363,6 +48363,8 @@ components:
           type: string
           x-okta-known-values:
           - ACTIVE_DIRECTORY
+      required:
+      - type
       type: object
     AppConfigActiveDirectory:
       allOf:

okta/client.go

@@ -68,7 +68,7 @@ var (
 )
 
 const (
-	VERSION                   = "6.1.0"
+	VERSION                   = "6.1.2"
 	AccessTokenCacheKey       = "OKTA_ACCESS_TOKEN"
 	DpopAccessTokenNonce      = "DPOP_OKTA_ACCESS_TOKEN_NONCE"
 	DpopAccessTokenPrivateKey = "DPOP_OKTA_ACCESS_TOKEN_PRIVATE_KEY"

okta/configuration.go

@@ -165,7 +165,7 @@ type Configuration struct {
 func NewConfiguration(conf ...ConfigSetter) (*Configuration, error) {
 	cfg := &Configuration{
 		DefaultHeader: make(map[string]string),
-		UserAgent:     fmt.Sprintf("okta-sdk-golang/%s golang/%s %s/%s", "6.1.0", runtime.Version(), runtime.GOOS, runtime.GOARCH),
+		UserAgent:     fmt.Sprintf("okta-sdk-golang/%s golang/%s %s/%s", "6.1.2", runtime.Version(), runtime.GOOS, runtime.GOARCH),
 		Debug:         false,
 		Servers: ServerConfigurations{
 			{

okta/docs/AppConfig.md

@@ -4,13 +4,13 @@
 
 Name | Type | Description | Notes
 ------------ | ------------- | ------------- | -------------
-**Type** | Pointer to **string** | The type of the app configuration | [optional] 
+**Type** | **string** | The type of the app configuration | 
 
 ## Methods
 
 ### NewAppConfig
 
-`func NewAppConfig() *AppConfig`
+`func NewAppConfig(type_ string, ) *AppConfig`
 
 NewAppConfig instantiates a new AppConfig object
 This constructor will assign default values to properties that have it defined,
@@ -44,11 +44,6 @@ and a boolean to check if the value has been set.
 
 SetType sets Type field to given value.
 
-### HasType
-
-`func (o *AppConfig) HasType() bool`
-
-HasType returns a boolean if a field has been set.
 
 
 [[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

okta/model_app_config.go

@@ -25,6 +25,7 @@ package okta
 
 import (
 	"encoding/json"
+	"fmt"
 )
 
 // checks if the AppConfig type satisfies the MappedNullable interface at compile time
@@ -33,7 +34,7 @@ var _ MappedNullable = &AppConfig{}
 // AppConfig Additional app configuration for group push mappings. Currently only required for Active Directory.
 type AppConfig struct {
 	// The type of the app configuration
-	Type                 *string `json:"type,omitempty"`
+	Type                 string `json:"type"`
 	AdditionalProperties map[string]interface{}
 }
 
@@ -43,8 +44,9 @@ type _AppConfig AppConfig
 // This constructor will assign default values to properties that have it defined,
 // and makes sure properties required by API are set, but the set of arguments
 // will change when the set of required properties is changed
-func NewAppConfig() *AppConfig {
+func NewAppConfig(type_ string) *AppConfig {
 	this := AppConfig{}
+	this.Type = type_
 	return &this
 }
 
@@ -56,36 +58,28 @@ func NewAppConfigWithDefaults() *AppConfig {
 	return &this
 }
 
-// GetType returns the Type field value if set, zero value otherwise.
+// GetType returns the Type field value
 func (o *AppConfig) GetType() string {
-	if o == nil || IsNil(o.Type) {
+	if o == nil {
 		var ret string
 		return ret
 	}
-	return *o.Type
+
+	return o.Type
 }
 
-// GetTypeOk returns a tuple with the Type field value if set, nil otherwise
+// GetTypeOk returns a tuple with the Type field value
 // and a boolean to check if the value has been set.
 func (o *AppConfig) GetTypeOk() (*string, bool) {
-	if o == nil || IsNil(o.Type) {
+	if o == nil {
 		return nil, false
 	}
-	return o.Type, true
-}
-
-// HasType returns a boolean if a field has been set.
-func (o *AppConfig) HasType() bool {
-	if o != nil && !IsNil(o.Type) {
-		return true
-	}
-
-	return false
+	return &o.Type, true
 }
 
-// SetType gets a reference to the given string and assigns it to the Type field.
+// SetType sets field value
 func (o *AppConfig) SetType(v string) {
-	o.Type = &v
+	o.Type = v
 }
 
 func (o AppConfig) MarshalJSON() ([]byte, error) {
@@ -98,9 +92,7 @@ func (o AppConfig) MarshalJSON() ([]byte, error) {
 
 func (o AppConfig) ToMap() (map[string]interface{}, error) {
 	toSerialize := map[string]interface{}{}
-	if !IsNil(o.Type) {
-		toSerialize["type"] = o.Type
-	}
+	toSerialize["type"] = o.Type
 
 	for key, value := range o.AdditionalProperties {
 		toSerialize[key] = value
@@ -110,6 +102,27 @@ func (o AppConfig) ToMap() (map[string]interface{}, error) {
 }
 
 func (o *AppConfig) UnmarshalJSON(data []byte) (err error) {
+	// This validates that all required properties are included in the JSON object
+	// by unmarshalling the object into a generic map with string keys and checking
+	// that every required field exists as a key in the generic map.
+	requiredProperties := []string{
+		"type",
+	}
+
+	allProperties := make(map[string]interface{})
+
+	err = json.Unmarshal(data, &allProperties)
+
+	if err != nil {
+		return err
+	}
+
+	for _, requiredProperty := range requiredProperties {
+		if _, exists := allProperties[requiredProperty]; !exists {
+			return fmt.Errorf("no value given for required property %v", requiredProperty)
+		}
+	}
+
 	varAppConfig := _AppConfig{}
 
 	err = json.Unmarshal(data, &varAppConfig)

okta/model_app_config_active_directory.go

@@ -53,8 +53,9 @@ type _AppConfigActiveDirectory AppConfigActiveDirectory
 // This constructor will assign default values to properties that have it defined,
 // and makes sure properties required by API are set, but the set of arguments
 // will change when the set of required properties is changed
-func NewAppConfigActiveDirectory(distinguishedName string, groupScope string, groupType string, samAccountName string) *AppConfigActiveDirectory {
+func NewAppConfigActiveDirectory(distinguishedName string, groupScope string, groupType string, samAccountName string, type_ string) *AppConfigActiveDirectory {
 	this := AppConfigActiveDirectory{}
+	this.Type = type_
 	return &this
 }
 
@@ -201,6 +202,7 @@ func (o *AppConfigActiveDirectory) UnmarshalJSON(data []byte) (err error) {
 		"groupScope",
 		"groupType",
 		"samAccountName",
+		"type",
 	}
 
 	allProperties := make(map[string]interface{})