Skip to content

Commit 7258003

Browse files
authored
Fixes generated array types (#84)
* Fixes generated array types - Fixes the generator type selector to properly set the type of an array when it's a custom type other than a string * Updates sms phone number for test
1 parent da407cb commit 7258003

10 files changed

Lines changed: 59 additions & 54 deletions

okta/logAuthenticationContext.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ package okta
2121
import ()
2222

2323
type LogAuthenticationContext struct {
24-
AuthenticationProvider string `json:"authenticationProvider,omitempty"`
25-
AuthenticationStep int64 `json:"authenticationStep,omitempty"`
26-
CredentialProvider []string `json:"credentialProvider,omitempty"`
27-
CredentialType []string `json:"credentialType,omitempty"`
28-
ExternalSessionId string `json:"externalSessionId,omitempty"`
29-
Interface string `json:"interface,omitempty"`
30-
Issuer *LogIssuer `json:"issuer,omitempty"`
24+
AuthenticationProvider string `json:"authenticationProvider,omitempty"`
25+
AuthenticationStep int64 `json:"authenticationStep,omitempty"`
26+
CredentialProvider []*LogCredentialProvider `json:"credentialProvider,omitempty"`
27+
CredentialType []*LogCredentialType `json:"credentialType,omitempty"`
28+
ExternalSessionId string `json:"externalSessionId,omitempty"`
29+
Interface string `json:"interface,omitempty"`
30+
Issuer *LogIssuer `json:"issuer,omitempty"`
3131
}

okta/logEvent.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ type LogEvent struct {
3939
Request *LogRequest `json:"request,omitempty"`
4040
SecurityContext *LogSecurityContext `json:"securityContext,omitempty"`
4141
Severity string `json:"severity,omitempty"`
42-
Target []string `json:"target,omitempty"`
42+
Target []*LogTarget `json:"target,omitempty"`
4343
Transaction *LogTransaction `json:"transaction,omitempty"`
4444
Uuid string `json:"uuid,omitempty"`
4545
Version string `json:"version,omitempty"`

okta/logRequest.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@ package okta
2121
import ()
2222

2323
type LogRequest struct {
24-
IpChain []string `json:"ipChain,omitempty"`
24+
IpChain []*LogIpAddress `json:"ipChain,omitempty"`
2525
}

okta/openIdConnectApplicationSettingsClient.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,16 @@ package okta
2121
import ()
2222

2323
type OpenIdConnectApplicationSettingsClient struct {
24-
ApplicationType string `json:"application_type,omitempty"`
25-
ClientUri string `json:"client_uri,omitempty"`
26-
ConsentMethod string `json:"consent_method,omitempty"`
27-
GrantTypes []string `json:"grant_types,omitempty"`
28-
LogoUri string `json:"logo_uri,omitempty"`
29-
PolicyUri string `json:"policy_uri,omitempty"`
30-
RedirectUris []string `json:"redirect_uris,omitempty"`
31-
ResponseTypes []string `json:"response_types,omitempty"`
32-
TosUri string `json:"tos_uri,omitempty"`
24+
ApplicationType string `json:"application_type,omitempty"`
25+
ClientUri string `json:"client_uri,omitempty"`
26+
ConsentMethod string `json:"consent_method,omitempty"`
27+
GrantTypes []*OAuthGrantType `json:"grant_types,omitempty"`
28+
LogoUri string `json:"logo_uri,omitempty"`
29+
PolicyUri string `json:"policy_uri,omitempty"`
30+
PostLogoutRedirectUris []string `json:"post_logout_redirect_uris,omitempty"`
31+
RedirectUris []string `json:"redirect_uris,omitempty"`
32+
ResponseTypes []*OAuthResponseType `json:"response_types,omitempty"`
33+
TosUri string `json:"tos_uri,omitempty"`
3334
}
3435

3536
func NewOpenIdConnectApplicationSettingsClient() *OpenIdConnectApplicationSettingsClient {

okta/samlApplicationSettingsSignOn.go

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,27 +21,27 @@ package okta
2121
import ()
2222

2323
type SamlApplicationSettingsSignOn struct {
24-
AssertionSigned *bool `json:"assertionSigned,omitempty"`
25-
AttributeStatements []string `json:"attributeStatements,omitempty"`
26-
Audience string `json:"audience,omitempty"`
27-
AudienceOverride string `json:"audienceOverride,omitempty"`
28-
AuthnContextClassRef string `json:"authnContextClassRef,omitempty"`
29-
DefaultRelayState string `json:"defaultRelayState,omitempty"`
30-
Destination string `json:"destination,omitempty"`
31-
DestinationOverride string `json:"destinationOverride,omitempty"`
32-
DigestAlgorithm string `json:"digestAlgorithm,omitempty"`
33-
HonorForceAuthn *bool `json:"honorForceAuthn,omitempty"`
34-
IdpIssuer string `json:"idpIssuer,omitempty"`
35-
Recipient string `json:"recipient,omitempty"`
36-
RecipientOverride string `json:"recipientOverride,omitempty"`
37-
RequestCompressed *bool `json:"requestCompressed,omitempty"`
38-
ResponseSigned *bool `json:"responseSigned,omitempty"`
39-
SignatureAlgorithm string `json:"signatureAlgorithm,omitempty"`
40-
SpIssuer string `json:"spIssuer,omitempty"`
41-
SsoAcsUrl string `json:"ssoAcsUrl,omitempty"`
42-
SsoAcsUrlOverride string `json:"ssoAcsUrlOverride,omitempty"`
43-
SubjectNameIdFormat string `json:"subjectNameIdFormat,omitempty"`
44-
SubjectNameIdTemplate string `json:"subjectNameIdTemplate,omitempty"`
24+
AssertionSigned *bool `json:"assertionSigned,omitempty"`
25+
AttributeStatements []*SamlAttributeStatement `json:"attributeStatements,omitempty"`
26+
Audience string `json:"audience,omitempty"`
27+
AudienceOverride string `json:"audienceOverride,omitempty"`
28+
AuthnContextClassRef string `json:"authnContextClassRef,omitempty"`
29+
DefaultRelayState string `json:"defaultRelayState,omitempty"`
30+
Destination string `json:"destination,omitempty"`
31+
DestinationOverride string `json:"destinationOverride,omitempty"`
32+
DigestAlgorithm string `json:"digestAlgorithm,omitempty"`
33+
HonorForceAuthn *bool `json:"honorForceAuthn,omitempty"`
34+
IdpIssuer string `json:"idpIssuer,omitempty"`
35+
Recipient string `json:"recipient,omitempty"`
36+
RecipientOverride string `json:"recipientOverride,omitempty"`
37+
RequestCompressed *bool `json:"requestCompressed,omitempty"`
38+
ResponseSigned *bool `json:"responseSigned,omitempty"`
39+
SignatureAlgorithm string `json:"signatureAlgorithm,omitempty"`
40+
SpIssuer string `json:"spIssuer,omitempty"`
41+
SsoAcsUrl string `json:"ssoAcsUrl,omitempty"`
42+
SsoAcsUrlOverride string `json:"ssoAcsUrlOverride,omitempty"`
43+
SubjectNameIdFormat string `json:"subjectNameIdFormat,omitempty"`
44+
SubjectNameIdTemplate string `json:"subjectNameIdTemplate,omitempty"`
4545
}
4646

4747
func NewSamlApplicationSettingsSignOn() *SamlApplicationSettingsSignOn {

okta/session.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,17 @@ import (
2626
type SessionResource resource
2727

2828
type Session struct {
29-
Links interface{} `json:"_links,omitempty"`
30-
Amr []string `json:"amr,omitempty"`
31-
CreatedAt *time.Time `json:"createdAt,omitempty"`
32-
ExpiresAt *time.Time `json:"expiresAt,omitempty"`
33-
Id string `json:"id,omitempty"`
34-
Idp *SessionIdentityProvider `json:"idp,omitempty"`
35-
LastFactorVerification *time.Time `json:"lastFactorVerification,omitempty"`
36-
LastPasswordVerification *time.Time `json:"lastPasswordVerification,omitempty"`
37-
Login string `json:"login,omitempty"`
38-
Status string `json:"status,omitempty"`
39-
UserId string `json:"userId,omitempty"`
29+
Links interface{} `json:"_links,omitempty"`
30+
Amr []*SessionAuthenticationMethod `json:"amr,omitempty"`
31+
CreatedAt *time.Time `json:"createdAt,omitempty"`
32+
ExpiresAt *time.Time `json:"expiresAt,omitempty"`
33+
Id string `json:"id,omitempty"`
34+
Idp *SessionIdentityProvider `json:"idp,omitempty"`
35+
LastFactorVerification *time.Time `json:"lastFactorVerification,omitempty"`
36+
LastPasswordVerification *time.Time `json:"lastPasswordVerification,omitempty"`
37+
Login string `json:"login,omitempty"`
38+
Status string `json:"status,omitempty"`
39+
UserId string `json:"userId,omitempty"`
4040
}
4141

4242
func (m *SessionResource) GetSession(sessionId string) (*Session, *Response, error) {

okta/userCredentials.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ package okta
2121
import ()
2222

2323
type UserCredentials struct {
24-
Emails []string `json:"emails,omitempty"`
24+
Emails []*EmailAddress `json:"emails,omitempty"`
2525
Password *PasswordCredential `json:"password,omitempty"`
2626
Provider *AuthenticationProvider `json:"provider,omitempty"`
2727
RecoveryQuestion *RecoveryQuestionCredential `json:"recovery_question,omitempty"`

openapi/generator/createdFiles.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

openapi/generator/index.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ function getType(obj, prefix="") {
3131
case 'hash' :
3232
return String.raw`interface{}`;
3333
case 'array' :
34-
return String.raw`[]string`;
34+
if(obj.model == undefined || obj.model === "string") {
35+
return String.raw`[]string`;
36+
} else {
37+
return String.raw`[]` + prefix + obj.model;
38+
}
3539
case 'enum' :
3640
case '':
3741
case 'null' :

tests/integration/factor_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ func Test_exercise_factor_lifecycle(t *testing.T) {
7070
assert.Empty(t, factors, "Factors list should be empty")
7171

7272
factorProfile := okta.NewSmsFactorProfile()
73-
factorProfile.PhoneNumber = "15055550006"
73+
factorProfile.PhoneNumber = "16284001133"
7474

7575
factor := okta.NewSmsFactor()
7676
factor.Profile = factorProfile

0 commit comments

Comments
 (0)