Skip to content

Commit bd0cc04

Browse files
committed
feat(msg-signing): update msg signing
update msg signing payload generation to be compatible with changes in DWN
1 parent cbfafd8 commit bd0cc04

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

Diff for: .changeset/honest-nails-unite.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@okto_web3/react-native-sdk": minor
3+
"@okto_web3/core-js-sdk": minor
4+
"@okto_web3/react-sdk": minor
5+
---
6+
7+
Update signMessage Payload Generation

Diff for: packages/core-js/src/core/signMessage.ts

+8-8
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,25 @@ export async function generateSignMessagePayload(
1414
message: string,
1515
signType: 'EIP191' | 'EIP712',
1616
): Promise<SignMessageParams> {
17+
//* Order of keys is important here
1718
const raw_message_to_sign = {
18-
message: message,
1919
requestType: signType,
20+
signingMessage: message,
2021
};
2122

2223
const transaction_id = generateUUID();
2324

2425
const base64_message_to_sign = {
25-
[transaction_id]: canonicalize(raw_message_to_sign),
26+
[transaction_id]: raw_message_to_sign,
2627
};
2728

28-
const base64_message = Buffer.from(
29-
canonicalize(base64_message_to_sign),
30-
).toString('base64');
29+
const base64_message = canonicalize(base64_message_to_sign);
3130

3231
const setup_options = {
3332
t: 3, // Threshold; 3,5 MPC
3433
key_id: userKeys.ecdsaKeyId,
3534
message: base64_message,
35+
// TODO: Add support for other signing algorithms (e.g. ed25519)
3636
signAlg: 'secp256k1',
3737
};
3838

@@ -46,16 +46,16 @@ export async function generateSignMessagePayload(
4646
const challenge = sha_2.toString('hex');
4747

4848
const enc = new TextEncoder();
49-
const paylaod = enc.encode(
49+
const rawMessagePayload = enc.encode(
5050
canonicalize({
51-
challenge: challenge,
5251
setup: setup_options,
52+
challenge: challenge,
5353
}),
5454
);
5555

5656
const sig = await signMessage({
5757
message: {
58-
raw: paylaod,
58+
raw: rawMessagePayload,
5959
},
6060
privateKey: session.sessionPrivKey,
6161
});

0 commit comments

Comments
 (0)