refactor: 振替先が新規なのか既存なのかを保存結果から判定するのではなく、作成した Destination オブジェクトで判定するように変更した。

Author: okuda0715tech

app/src/main/java/com/kurodai0715/directdebitmanager/domain/usecase/SourcesCommandUseCase.kt

@@ -10,8 +10,7 @@ import com.kurodai0715.directdebitmanager.domain.model.Destination
 import javax.inject.Inject
 
 sealed interface SaveResult {
-    data object Created : SaveResult
-    data object Updated : SaveResult
+    data object Succeeded : SaveResult
     data object Failed : SaveResult
 }
 
@@ -30,7 +29,7 @@ class SourcesCommandUseCase @Inject constructor(
                     parentId = destination.parentId,
                 )
                 when (result) {
-                    true -> SaveResult.Created
+                    true -> SaveResult.Succeeded
                     false -> SaveResult.Failed
                 }
             }
@@ -43,7 +42,7 @@ class SourcesCommandUseCase @Inject constructor(
                     parentId = destination.parentId,
                 )
                 when (result) {
-                    true -> SaveResult.Updated
+                    true -> SaveResult.Succeeded
                     false -> SaveResult.Failed
                 }
             }

app/src/main/java/com/kurodai0715/directdebitmanager/ui/screen/destination_edit/DestinationEditViewModel.kt

@@ -422,23 +422,18 @@ class DestinationEditViewModel @Inject constructor(
 
             val result = saveDestination(dest)
 
-            handleResult(result)
-        }
-    }
+            when (result) {
+                SaveResult.Succeeded -> {
+                    if (dest is Destination.New) {
+                        // 新規作成の場合は、入力フォームを初期化
+                        _formInputState.update { FormInputState() }
+                    }
+                    _eventChannel.send(UiEvent.ShowSnackbar(R.string.common_save_successfully))
+                }
 
-    private suspend fun handleResult(result: SaveResult) {
-        when (result) {
-            SaveResult.Created -> {
-                // 入力フォームを初期化
-                _formInputState.update { FormInputState() }
-                _eventChannel.send(UiEvent.ShowSnackbar(R.string.common_save_successfully))
+                SaveResult.Failed ->
+                    _eventChannel.send(UiEvent.ShowSnackbar(R.string.common_save_failed))
             }
-
-            SaveResult.Updated ->
-                _eventChannel.send(UiEvent.ShowSnackbar(R.string.common_save_successfully))
-
-            SaveResult.Failed ->
-                _eventChannel.send(UiEvent.ShowSnackbar(R.string.common_save_failed))
         }
     }