Skip to content

Commit d956280

Browse files
olaservoclaude
andcommitted
Drop custom instruction; read model from scenario YAML
Two related contamination-control changes for the Scenario #1 harness: - Remove the custom `instruction=` kwarg. Fast-agent now falls through to DEFAULT_AGENT_INSTRUCTION so the activation test sees only this CLI's native system prompt plus the scenario's user prompt. The old string named "GitHub pull request workflows", priming the model toward the skill's domain ahead of how Gemini CLI and Codex are configured (neither injects a custom system prompt). - Read the model from the scenario's per-client `models:` map instead of letting fastagent.config.yaml's `default_model` drive the choice. Model selection belongs in the shared scenario so every client (and every run) is explicit and reproducible. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 1378687 commit d956280

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

scripts/skills_e2e_agent/agent.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -255,10 +255,11 @@ def _evaluate(calls: list[tuple[str, dict]]) -> dict:
255255

256256
@fast.agent(
257257
name="pr_reviewer",
258-
instruction=(
259-
"You are a software engineer assisting with GitHub pull request "
260-
"workflows. {{agentSkills}}"
261-
),
258+
# No custom instruction — fall through to fast-agent's
259+
# DEFAULT_AGENT_INSTRUCTION (constants.py) so the activation test sees
260+
# only this CLI's native system prompt + the scenario user prompt,
261+
# matching how Gemini CLI and Codex runners are configured.
262+
model=SCENARIO.get("models", {}).get("fast-agent"),
262263
servers=["github_skills"],
263264
)
264265
async def main() -> int:

0 commit comments

Comments
 (0)