Updated "no-regen-url-key" code. Updated README and CHANGELOG.

Author: olegkoval

CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.4.3] - 2019-05-12
+### Added
+- new option "no-regen-url-key"
+
+### Changed
+- fixed a "typo" issue
+
 ## [1.4.2] - 2019-04-04
 ### Added
 - new option "--check-use-category-in-product-url"

Console/Command/RegenerateUrlRewrites.php

@@ -112,7 +112,7 @@ protected function configure()
                     self::INPUT_KEY_NO_REGEN_URL_KEY,
                     null,
                     InputOption::VALUE_NONE,
-                    'Prevent URL_key regeneration'
+                    'Prevent url_key regeneration'
                 ),       
             ]);
     }
@@ -220,6 +220,10 @@ public function getCommandOptions()
             $this->_commandOptions['saveOldUrls'] = true;
         }
 
+        if (isset($options[self::INPUT_KEY_NO_REGEN_URL_KEY]) && $options[self::INPUT_KEY_NO_REGEN_URL_KEY] === true) {
+            $this->_commandOptions['noRegenUrlKey'] = true;
+        }
+
         if (isset($options[self::INPUT_KEY_NO_REINDEX]) && $options[self::INPUT_KEY_NO_REINDEX] === true) {
             $this->_commandOptions['runReindex'] = false;
         }

Console/Command/RegenerateUrlRewritesAbstract.php

@@ -259,7 +259,7 @@ public function __construct(
         $this->_commandOptions['categoryId'] = null;
         $this->_commandOptions['productId'] = null;
         $this->_commandOptions['checkUseCategoryInProductUrl'] = false;
-        $this->_commandOptions[SELF::INPUT_KEY_NO_REGEN_URL_KEY] = false;
+        $this->_commandOptions['noRegenUrlKey'] = false;
     }
 
     /**

Console/Command/RegenerateUrlRewritesCategoryAbstract.php

@@ -73,10 +73,7 @@ protected function _categoryProcess($category, $storeId = 0)
             }
             $category->setStoreId($storeId);
 
-            if(!$this->_commandOptions[SELF::INPUT_KEY_NO_REGEN_URL_KEY]) {
-                $category->setData('url_key', null);
-
-                // URL Key needs to be regenerated before url_path, otherwise it may discord
+            if (!$this->_commandOptions['noRegenUrlKey']) {
                 $category->setUrlKey($this->_categoryUrlPathGenerator->getUrlKey($category));
                 $category->getResource()->saveAttribute($category, 'url_key');
             }

Console/Command/RegenerateUrlRewritesProductAbstract.php

@@ -77,27 +77,18 @@ protected function _productProcess($product, $storeId)
             $product->setData('url_path', null)
                     ->setStoreId($storeId);
 
-            if(!$this->_commandOptions[SELF::INPUT_KEY_NO_REGEN_URL_KEY]) {
-                $product->setData('url_key', null);
-
+            if (!$this->_commandOptions['noRegenUrlKey']) {
                 $generatedKey = $this->_productUrlPathGenerator->getUrlKey($product);
 
+                $product->setData('url_key', $generatedKey);
+
                 $this->_getProductAction()->updateAttributes(
                     [$product->getId()],
-                    ['url_key' => $generatedKey],
+                    ['url_path' => null, 'url_key' => $generatedKey],
                     $storeId
                 );
-
-                $product->setData('url_key', $generatedKey);
             }
 
-            $this->_getProductAction()->updateAttributes(
-                [$product->getId()],
-                ['url_path' => null],
-                $storeId
-            );
-
-
             $productUrlRewriteResult = $this->_getProductUrlRewriteGenerator()->generate($product);
 
             $productUrlRewriteResult = $this->_sanitizeProductUrlRewrites($productUrlRewriteResult);

README.md

@@ -75,6 +75,9 @@ or
 * to save a current URL rewrites (you want to get a new URL rewites and save current) use option `--save-old-urls`:
 >`$> php bin/magento ok:urlrewrites:regenerate --save-old-urls`
 
+* to prevent regeneration of "url_key" values (use current "url_key" values) use option `--no-regen-url-key`:
+>`$> php bin/magento ok:urlrewrites:regenerate --no-regen-url-key`
+
 * do not run full reindex at the end of URL rewrites generation use option `--no-reindex`:
 >`$> php bin/magento ok:urlrewrites:regenerate --no-reindex`
 
@@ -88,7 +91,7 @@ or
 >`$> php bin/magento ok:urlrewrites:regenerate --no-progress`
 
 ### YOU CAN COMBINE OPTIONS
->`$> php bin/magento ok:urlrewrites:regenerate --store-id=2 --save-old-urls --no-reindex`
+>`$> php bin/magento ok:urlrewrites:regenerate --store-id=2 --save-old-urls --no-regen-url-key --no-reindex`
 
 ### YOU CAN NOT COMBINE THIS OPTIONS TOGETHER
 * `--entity-type=product` and `--category-id`/`--categories-range`

composer.json

@@ -3,7 +3,7 @@
     "description": "Add into Magento 2 a CLI feature which allow to regenerate a Url rewrites of products and categories",
     "keywords": ["magento", "magento2 extension", "magento 2 extension", "extension", "module", "magento2 module", "magento 2 module"],
     "type": "magento2-module",
-    "version": "1.4.2",
+    "version": "1.4.3",
     "homepage": "https://github.com/olegkoval/magento2-regenerate_url_rewrites",
     "authors": [
         {

etc/module.xml

@@ -10,7 +10,7 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="OlegKoval_RegenerateUrlRewrites" setup_version="1.4.2">
+    <module name="OlegKoval_RegenerateUrlRewrites" setup_version="1.4.3">
         <sequence>
             <module name="Magento_Store"/>
             <module name="Magento_Catalog"/>