Skip to content

Commit 9decf25

Browse files
olegkovalolegkoval
committed
Fixed compilation issues
1 parent 484cb78 commit 9decf25

6 files changed

+29
-37
lines changed

‎CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## [1.2.1] - 2018-09-25
8+
### Changed
9+
- fixed compilation issues
10+
711
## [1.2.0] - 2018-09-25
812
### Changed
913
- added proxies to CLI commands

‎Console/Command/RegenerateUrlRewrites.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
119119
$this->_output->writeln('Cache refreshing...');
120120
shell_exec('php bin/magento cache:clean');
121121
shell_exec('php bin/magento cache:flush');
122-
$this->_output->writeln('If you use some external cache mechanisms (e.g.: Redis, Varnish, etc.) - please, refresh the cache.');
122+
$this->_output->writeln('If you use some external cache mechanisms (e.g.: Redis, Varnish, etc.) - please, refresh this external cache.');
123123
$this->_output->writeln('Finished');
124124
}
125125

‎Console/Command/RegenerateUrlRewritesAbstract.php

+22-22
Original file line numberDiff line numberDiff line change
@@ -134,33 +134,33 @@ abstract class RegenerateUrlRewritesAbstract extends Command
134134
protected $_runReindex = true;
135135

136136
/**
137-
*
138-
*
139-
* @param ResourceConnection $resource
140-
* @param CategoryCollectionFactory $categoryCollectionFactory
141-
* @param ProductCollectionFactory $productCollectionFactory
142-
* @param UrlPersist $urlPersist
143-
* @param CategoryHelper $categoryHelper
144-
* @param CategoryUrlRewriteGenerator $categoryUrlRewriteGeneratorFactory
145-
* @param UrlRewriteBunchReplacer $urlRewriteBunchReplacer
146-
* @param UrlRewriteHandler $urlRewriteHandlerFactory
147-
* @param DatabaseMapPool $databaseMapPool
148-
* @param array $dataUrlRewriteClassNames
149-
* @param AppState $appState
137+
* Constructor
138+
* @param ResourceConnection $resource
139+
* @param CategoryCollectionFactory $categoryCollectionFactory
140+
* @param ProductCollectionFactory $productCollectionFactory
141+
* @param UrlPersist\Proxy $urlPersist
142+
* @param CategoryHelper\Proxy $categoryHelper
143+
* @param CategoryUrlRewriteGeneratorFactory\Proxy $categoryUrlRewriteGeneratorFactory
144+
* @param ProductUrlRewriteGeneratorFactory\Proxy $productUrlRewriteGeneratorFactory
145+
* @param UrlRewriteBunchReplacer\Proxy $urlRewriteBunchReplacer
146+
* @param UrlRewriteHandlerFactory\Proxy $urlRewriteHandlerFactory
147+
* @param DatabaseMapPool\Proxy $databaseMapPool
148+
* @param ProductActionFactory\Proxy $productActionFactory
149+
* @param AppState\Proxy $appState
150150
*/
151151
public function __construct(
152152
ResourceConnection $resource,
153153
CategoryCollectionFactory $categoryCollectionFactory,
154154
ProductCollectionFactory $productCollectionFactory,
155-
UrlPersist $urlPersist,
156-
CategoryHelper $categoryHelper,
157-
CategoryUrlRewriteGeneratorFactory $categoryUrlRewriteGeneratorFactory,
158-
ProductUrlRewriteGeneratorFactory $productUrlRewriteGeneratorFactory,
159-
UrlRewriteBunchReplacer $urlRewriteBunchReplacer,
160-
UrlRewriteHandlerFactory $urlRewriteHandlerFactory,
161-
DatabaseMapPool $databaseMapPool,
162-
ProductActionFactory $productActionFactory,
163-
AppState $appState
155+
UrlPersist\Proxy $urlPersist,
156+
CategoryHelper\Proxy $categoryHelper,
157+
CategoryUrlRewriteGeneratorFactory\Proxy $categoryUrlRewriteGeneratorFactory,
158+
ProductUrlRewriteGeneratorFactory\Proxy $productUrlRewriteGeneratorFactory,
159+
UrlRewriteBunchReplacer\Proxy $urlRewriteBunchReplacer,
160+
UrlRewriteHandlerFactory\Proxy $urlRewriteHandlerFactory,
161+
DatabaseMapPool\Proxy $databaseMapPool,
162+
ProductActionFactory\Proxy $productActionFactory,
163+
AppState\Proxy $appState
164164
) {
165165
$this->_resource = $resource;
166166
$this->_categoryCollectionFactory = $categoryCollectionFactory;

‎composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"description": "Add into Magento 2 a CLI feature which allow to regenerate a Url rewrites of products/categories",
44
"keywords": ["magento", "magento2 extension", "magento 2 extension", "extension", "module", "magento2 module", "magento 2 module"],
55
"type": "magento2-module",
6-
"version": "1.2.0",
6+
"version": "1.2.1",
77
"homepage": "https://github.com/olegkoval/magento2-regenerate_url_rewrites",
88
"authors": [
99
{

‎etc/di.xml

-12
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,6 @@
1515
<argument name="commands" xsi:type="array">
1616
<item name="ok:urlrewrites:regenerate" xsi:type="object">OlegKoval\RegenerateUrlRewrites\Console\Command\RegenerateUrlRewrites</item>
1717
</argument>
18-
<argument name="resource" xsi:type="object">ResourceConnection\Proxy</argument>
19-
<argument name="categoryCollectionFactory" xsi:type="object">CategoryCollectionFactory\Proxy</argument>
20-
<argument name="productCollectionFactory" xsi:type="object">ProductCollectionFactory\Proxy</argument>
21-
<argument name="urlPersist" xsi:type="object">UrlPersist\Proxy</argument>
22-
<argument name="categoryHelper" xsi:type="object">CategoryHelper\Proxy</argument>
23-
<argument name="categoryUrlRewriteGeneratorFactory" xsi:type="object">CategoryUrlRewriteGeneratorFactory\Proxy</argument>
24-
<argument name="productUrlRewriteGeneratorFactory" xsi:type="object">ProductUrlRewriteGeneratorFactory\Proxy</argument>
25-
<argument name="urlRewriteBunchReplacer" xsi:type="object">UrlRewriteBunchReplacer\Proxy</argument>
26-
<argument name="urlRewriteHandlerFactory" xsi:type="object">UrlRewriteHandlerFactory\Proxy</argument>
27-
<argument name="databaseMapPool" xsi:type="object">DatabaseMapPool\Proxy</argument>
28-
<argument name="productActionFactory" xsi:type="object">ProductActionFactory\Proxy</argument>
29-
<argument name="appState" xsi:type="object">AppState\Proxy</argument>
3018
</arguments>
3119
</type>
3220
</config>

‎etc/module.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111
-->
1212
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
13-
<module name="OlegKoval_RegenerateUrlRewrites" setup_version="1.2.0">
13+
<module name="OlegKoval_RegenerateUrlRewrites" setup_version="1.2.1">
1414
<sequence>
1515
<module name="Magento_Store"/>
1616
<module name="Magento_Catalog"/>

0 commit comments

Comments
 (0)