Merge pull request #104 from olexale/fix-hook-failure-reporting

Refactor error handling in hooks to use catch instead of on TestFailure

Author: olexale

CHANGELOG.md

@@ -3,6 +3,7 @@
 * **BREAKING CHANGE**: The package doesn't provide pre-built steps anymore. Steps will appear in the `step` folder.
 * Drop unused dependencies
 * Upgrade `build` dependency
+* Fix exceptions processing in hooks
 
 ## [1.8.2] - Ignore linter warnings
 

lib/src/scenario_generator.dart

@@ -38,7 +38,7 @@ void parseScenario(
   }
 
   if (hasHooks) {
-    sb.writeln('      } on TestFailure {');
+    sb.writeln('      } catch (_) {');
     sb.writeln('        $testSuccessVariableName = false;');
     sb.writeln('        rethrow;');
   }

test/feature_generator_test.dart

@@ -136,7 +136,7 @@ hookFolderName: hooksFolder
         '      try {\n'
         "        await beforeEach('''Testing scenario''');\n"
         '        await theAppIsRunning(tester);\n'
-        '      } on TestFailure {\n'
+        '      } catch (_) {\n'
         '        success = false;\n'
         '        rethrow;\n'
         '      } finally {\n'

test/feature_with_hooks_test.dart

@@ -36,7 +36,7 @@ void main() {
       try {
       await beforeEach(\'\'\'Testing scenario\'\'\' );
       await theAppIsRunning(tester);
-      } on TestFailure {
+      } catch (_) {
         success = false;
         rethrow;
       } finally {

test/full_set_test.dart

@@ -67,7 +67,7 @@ void main() {
         await theAppIsRunning(tester);
         await iRunCode(tester, 'func foo() {}; func bar() { print("hey!"); };');
         await iSeeText(tester, '0');
-      } on TestFailure {
+      } catch (_) {
         success = false;
         rethrow;
       } finally {
@@ -96,7 +96,7 @@ void main() {
       await beforeEach(\'\'\'Initial counter value is 0\'\'\' );
       await bddSetUp(tester);
       await theAppIsRunning(tester);
-      } on TestFailure {
+      } catch (_) {
         success = false;
         rethrow;
       } finally {