fixed memory leak when replacing data on table with nested data

olifolkerd · Jan 19, 2025 · d240a35 · d240a35
1 parent 000373b
commit d240a35
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 2 deletions.
diff --git a/dist/js/tabulator_esm.js b/dist/js/tabulator_esm.js
@@ -4395,6 +4395,7 @@ class DataTree extends Module{
 
 			this.subscribe("row-init", this.initializeRow.bind(this));
 			this.subscribe("row-layout-after", this.layoutRow.bind(this));
+			this.subscribe("row-deleting", this.rowDeleting.bind(this));
 			this.subscribe("row-deleted", this.rowDelete.bind(this),0);
 			this.subscribe("row-data-changed", this.rowDataChanged.bind(this), 10);
 			this.subscribe("cell-value-updated", this.cellValueChanged.bind(this));
@@ -4734,6 +4735,18 @@ class DataTree extends Module{
 		return output;
 	}
 
+	rowDeleting(row){
+		var config = row.modules.dataTree;
+
+		if (config && config.children && Array.isArray(config.children)){
+			config.children.forEach((childRow) => {
+				if(childRow instanceof Row){
+					childRow.wipe();
+				}
+			});
+		}
+	}
+
 	rowDelete(row){
 		var parent = row.modules.dataTree.parent,
 		childIndex;

diff --git a/dist/js/tabulator_esm.js.map b/dist/js/tabulator_esm.js.map
diff --git a/dist/js/tabulator_esm.mjs b/dist/js/tabulator_esm.mjs
@@ -4395,6 +4395,7 @@ class DataTree extends Module{
 
 			this.subscribe("row-init", this.initializeRow.bind(this));
 			this.subscribe("row-layout-after", this.layoutRow.bind(this));
+			this.subscribe("row-deleting", this.rowDeleting.bind(this));
 			this.subscribe("row-deleted", this.rowDelete.bind(this),0);
 			this.subscribe("row-data-changed", this.rowDataChanged.bind(this), 10);
 			this.subscribe("cell-value-updated", this.cellValueChanged.bind(this));
@@ -4734,6 +4735,18 @@ class DataTree extends Module{
 		return output;
 	}
 
+	rowDeleting(row){
+		var config = row.modules.dataTree;
+
+		if (config && config.children && Array.isArray(config.children)){
+			config.children.forEach((childRow) => {
+				if(childRow instanceof Row){
+					childRow.wipe();
+				}
+			});
+		}
+	}
+
 	rowDelete(row){
 		var parent = row.modules.dataTree.parent,
 		childIndex;

diff --git a/dist/js/tabulator_esm.mjs.map b/dist/js/tabulator_esm.mjs.map
diff --git a/src/js/modules/DataTree/DataTree.js b/src/js/modules/DataTree/DataTree.js
@@ -125,6 +125,7 @@ export default class DataTree extends Module{
 
 			this.subscribe("row-init", this.initializeRow.bind(this));
 			this.subscribe("row-layout-after", this.layoutRow.bind(this));
+			this.subscribe("row-deleting", this.rowDeleting.bind(this));
 			this.subscribe("row-deleted", this.rowDelete.bind(this),0);
 			this.subscribe("row-data-changed", this.rowDataChanged.bind(this), 10);
 			this.subscribe("cell-value-updated", this.cellValueChanged.bind(this));
@@ -464,6 +465,18 @@ export default class DataTree extends Module{
 		return output;
 	}
 
+	rowDeleting(row){
+		var config = row.modules.dataTree;
+
+		if (config && config.children && Array.isArray(config.children)){
+			config.children.forEach((childRow) => {
+				if(childRow instanceof Row){
+					childRow.wipe();
+				}
+			});
+		}
+	}
+
 	rowDelete(row){
 		var parent = row.modules.dataTree.parent,
 		childIndex;