feat(acp): fire CodeCompanionACPSessionPre event before session establishment#2938
Merged
Merged
Conversation
olimorris
reviewed
Mar 26, 2026
olimorris
reviewed
Mar 26, 2026
olimorris
reviewed
Mar 26, 2026
olimorris
left a comment
olimorris
left a comment
Owner
There was a problem hiding this comment.
All looks good to me. We can just streamline the docs and the test
Contributor
Author
|
Sure! Want a more single-line doc entry? And for tests? |
…lishment
Fire the User event 'ACPSessionPre' (which Neovim broadcasts as
'CodeCompanionACPSessionPre') after connect_and_authenticate() succeeds
but before _establish_session() runs in both:
- Connection:connect_and_initialize() - initial connection path
- Connection:ensure_session() - reconnection path
This gives consumers a synchronous hook to inspect _agent_info
(populated after INITIALIZE RPC) and modify adapter_modified.defaults
(e.g. mcpServers) before the session/new request is sent.
The event data includes { connection = self } so handlers have full
access to the connection object.
georgeharker
force-pushed
the
acp-extension-hook
branch
from
33c1b9d to
544b306
Compare
georgeharker
commented
Mar 26, 2026
georgeharker
left a comment
georgeharker
left a comment
Contributor
Author
There was a problem hiding this comment.
resolved the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fire the User event 'ACPSessionPre' (which Neovim broadcasts as 'CodeCompanionACPSessionPre') after connect_and_authenticate() succeeds but before _establish_session() runs in both:
This gives consumers a synchronous hook to inspect _agent_info (populated after INITIALIZE RPC) and modify adapter_modified.defaults (e.g. mcpServers) before the session/new request is sent.
The event data includes { connection = self } so handlers have full access to the connection object.
AI Usage
Ai for documentation updates, adding tests.
Related Issue(s)
#2932
Screenshots
n/a
Checklist
make allto ensure docs are generated, tests pass and StyLua has formatted the code