Commit 284ba94
committed
fix(amp): replace the impossible phx-watch-pr install command
README and docs/amp.md told users to install the watcher with `amp plugins
add` against a raw.githubusercontent.com URL. Amp rejects that outright:
Error: For now, only https://ampcode.com/@amp/plugins/*.ts and
https://ampcode.com/@amp/plugins/*.ts URLs are allowed.
Verified on Amp 0.0.1787045288. Nothing is written, so the documented path
to the watcher never worked for anyone.
docs/amp.md already contradicted itself about this: 390 lines below the
install block it states that Amp "restricts `amp plugins add` ... to
Amp-hosted plugins" and hands out an atomic curl for elixir-phoenix.ts. The
install instruction was simply the wrong half of the contradiction. Both
call sites now use that same curl + mv pattern against the standalone
repository's stable branch, verified to fetch bytes identical to the
canonical target. The update section loops over both plugins rather than
only the workflow one.
Also raises the phx-watch-pr harness subprocess timeout from 60s to 240s.
The harness drives a fake clock with real 80ms flushes -- advance() runs up
to 21 per call across 23 calls -- so it spends ~59s waiting for ~3s of CPU.
Consecutive local runs took 58.9s, 60.4s, and 73.9s, so a required check
was passing or failing on runner load alone. The harness is unchanged;
shortening the flush would swap a timeout flake for a race.
Fixes a paragraph-join in README introduced when the watch-pr block was
merged forward in #132.1 parent 7c613bd commit 284ba94
4 files changed
Lines changed: 52 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
102 | 123 | | |
103 | 124 | | |
104 | 125 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
| 309 | + | |
309 | 310 | | |
310 | 311 | | |
311 | 312 | | |
312 | 313 | | |
313 | | - | |
314 | | - | |
315 | | - | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
316 | 320 | | |
317 | 321 | | |
318 | 322 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
116 | | - | |
117 | | - | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
118 | 121 | | |
119 | 122 | | |
120 | 123 | | |
| |||
501 | 504 | | |
502 | 505 | | |
503 | 506 | | |
504 | | - | |
505 | | - | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
506 | 510 | | |
507 | 511 | | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
516 | 523 | | |
517 | 524 | | |
518 | 525 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
446 | | - | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
447 | 450 | | |
448 | 451 | | |
449 | 452 | | |
| |||
0 commit comments