Deduplicate cluster connection: create once and reuse for key checks and key groups

Author: oliver006

exporter/exporter.go

@@ -846,21 +846,19 @@ func (e *Exporter) scrapeRedisHost(ch chan<- prometheus.Metric) error {
 		e.extractLatencyMetrics(ch, infoAll, c)
 	}
 
+	// For key-based operations, use cluster connection if in cluster mode
+	keyConn, keyConnErr := e.getKeyOperationConnection(c)
+	if keyConnErr != nil {
+		log.Errorf("failed to get key operation connection: %s", keyConnErr)
+	} else if keyConn != c {
+		defer keyConn.Close()
+	}
+
 	// skip these metrics for master if SkipCheckKeysForRoleMaster is set
 	// (can help with reducing workload on the master node)
 	log.Debugf("checkKeys metric collection for role: %s  SkipCheckKeysForRoleMaster flag: %#v", role, e.options.SkipCheckKeysForRoleMaster)
 	if role == InstanceRoleSlave || !e.options.SkipCheckKeysForRoleMaster {
-		// For key-based operations, use cluster connection if in cluster mode
-		keyConn, err := e.getKeyOperationConnection(c)
-		if err != nil {
-			log.Errorf("failed to get key operation connection: %s", err)
-		} else {
-			defer func() {
-				if keyConn != c {
-					keyConn.Close()
-				}
-			}()
-
+		if keyConnErr == nil {
 			if err := e.extractCheckKeyMetrics(ch, keyConn); err != nil {
 				log.Errorf("extractCheckKeyMetrics() err: %s", err)
 			}
@@ -875,17 +873,8 @@ func (e *Exporter) scrapeRedisHost(ch chan<- prometheus.Metric) error {
 
 	e.extractSlowLogMetrics(ch, c)
 
-	// Key groups also need cluster connection for key operations
-	keyGroupConn, err := e.getKeyOperationConnection(c)
-	if err != nil {
-		log.Errorf("failed to get key operation connection for key groups: %s", err)
-	} else {
-		defer func() {
-			if keyGroupConn != c {
-				keyGroupConn.Close()
-			}
-		}()
-		e.extractKeyGroupMetrics(ch, keyGroupConn, dbCount)
+	if keyConnErr == nil {
+		e.extractKeyGroupMetrics(ch, keyConn, dbCount)
 	}
 
 	if strings.Contains(infoAll, "# Sentinel") {