Add Support for php etl 1.0 .

Author: oliverde8

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 1.0.0 
+- :confetti_ball: :tada: First stable release :tada: :confetti_ball:
+- :star2: Added support for php etl 1.0 stable release.
+- :star2: Added support for symfony 6
+- :wrench: Download of ETL file execution will now work with even big files. (Not limited by memory)
 
 # 1.0.0 Alpha #2
 

Controller/Admin/EtlDownloadFileController.php

@@ -6,24 +6,26 @@
 use Oliverde8\PhpEtlBundle\Entity\EtlExecution;
 use Oliverde8\PhpEtlBundle\Security\EtlExecutionVoter;
 use Oliverde8\PhpEtlBundle\Services\ChainWorkDirManager;
+use Oliverde8\PhpEtlBundle\Services\ExecutionContextFactory;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\HeaderUtils;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\StreamedResponse;
 use Symfony\Component\Routing\Annotation\Route;
 
 class EtlDownloadFileController extends AbstractController
 {
-    /** @var ChainWorkDirManager */
-    protected $chainWorkDirManager;
+    /** @var ExecutionContextFactory */
+    protected $executionContextFactory;
 
     /**
-     * EtlDownloadFileController constructor.
-     * @param ChainWorkDirManager $chainWorkDirManager
+     * @param ExecutionContextFactory $executionContextFactory
      */
-    public function __construct(ChainWorkDirManager $chainWorkDirManager)
+    public function __construct(ExecutionContextFactory $executionContextFactory)
     {
-        $this->chainWorkDirManager = $chainWorkDirManager;
+        $this->executionContextFactory = $executionContextFactory;
     }
 
     /**
@@ -34,10 +36,20 @@ public function index(EtlExecution $execution, string $filename): Response
     {
         $this->denyAccessUnlessGranted(EtlExecutionVoter::DOWNLOAD, EtlExecution::class);
 
-        //TODO add Acl here for future proofing.
-        return $this->file(
-            $this->chainWorkDirManager->getWorkDir($execution) . "/" . $filename,
+        $context = $this->executionContextFactory->get(['etl' => ['execution' => $execution]]);
+        $file = $context->getFileSystem()->readStream($filename);
+
+        $response = new StreamedResponse(function () use ($file) {
+            $outputStream = fopen('php://output', 'wb');
+            stream_copy_to_stream($file, $outputStream);
+        });
+
+        $disposition = HeaderUtils::makeDisposition(
+            HeaderUtils::DISPOSITION_ATTACHMENT,
             "execution-{$execution->getName()}-{$execution->getId()}-" . $filename
         );
+        $response->headers->set('Content-Disposition', $disposition);
+
+        return $response;
     }
 }

Controller/Admin/EtlExecutionCrudController.php

@@ -20,34 +20,30 @@
 use Oliverde8\PhpEtlBundle\Security\EtlExecutionVoter;
 use Oliverde8\PhpEtlBundle\Services\ChainProcessorsManager;
 use Oliverde8\PhpEtlBundle\Services\ChainWorkDirManager;
+use Oliverde8\PhpEtlBundle\Services\ExecutionContextFactory;
 
 class EtlExecutionCrudController extends AbstractCrudController
 {
-    /** @var ChainWorkDirManager */
-    protected $chainWorkDirManager;
+    /** @var ExecutionContextFactory */
+    protected $executionContextFactory;
 
     /** @var ChainProcessorsManager */
     protected $chainProcessorManager;
 
     /** @var AdminUrlGenerator */
     protected $adminUrlGenerator;
 
-    /**
-     * EtlExecutionCrudController constructor.
-     * @param ChainWorkDirManager $chainWorkDirManager
-     * @param ChainProcessorsManager $chainProcessorManager
-     * @param AdminUrlGenerator $adminUrlGenerator
-     */
     public function __construct(
-        ChainWorkDirManager $chainWorkDirManager,
+        ExecutionContextFactory $executionContextFactory,
         ChainProcessorsManager $chainProcessorManager,
         AdminUrlGenerator $adminUrlGenerator
     ) {
-        $this->chainWorkDirManager = $chainWorkDirManager;
+        $this->executionContextFactory = $executionContextFactory;
         $this->chainProcessorManager = $chainProcessorManager;
         $this->adminUrlGenerator = $adminUrlGenerator;
     }
 
+
     public static function getEntityFqcn(): string
     {
         return EtlExecution::class;
@@ -105,21 +101,35 @@ public function configureFields(string $pageName): iterable
                 TextField::new('Files')->formatValue(function ($value, EtlExecution $entity) {
                     $urls = [];
                     if ($this->isGranted(EtlExecutionVoter::DOWNLOAD, EtlExecution::class)) {
-                        $files = $this->chainWorkDirManager->listFiles($entity);
+
+                        $context = $this->executionContextFactory->get(['etl' => ['execution' => $entity]]);
+                        $files = $context->getFileSystem()->listContents("/");
                         foreach ($files as $file) {
-                            $url = $this->adminUrlGenerator
-                                ->setRoute("etl_execution_download_file", ['execution' => $entity->getId(), 'filename' => $file])
-                                ->generateUrl();
+                            if (strpos($file, '.') !== 0) {
+                                $url = $this->adminUrlGenerator
+                                    ->setRoute("etl_execution_download_file", ['execution' => $entity->getId(), 'filename' => $file])
+                                    ->generateUrl();
 
-                            $urls[$url] = $file;
+                                $urls[$url] = $file;
+                            }
                         }
                     }
 
                     return $urls;
                 })->setTemplatePath('@Oliverde8PhpEtlEasyAdmin/fields/files.html.twig'),
+
                 CodeEditorField::new('errorMessage')->setTemplatePath('@Oliverde8PhpEtlEasyAdmin/fields/code_editor.html.twig'),
                 TextField::new('Logs')->formatValue(function ($value, EtlExecution $entity) {
-                    $logs = $this->chainWorkDirManager->getFirstLogLines($entity, 100);
+                    $context = $this->executionContextFactory->get(['etl' => ['execution' => $entity]]);
+                    $logs = [];
+                    $file = $context->getFileSystem()->readStream("execution.log");
+                    $i = 0;
+                    while ($i < 100 && $line = fgets($file)) {
+                        $logs[] = $line;
+                        $i++;
+                    }
+                    fclose($file);
+
                     $url = "";
                     $moreLogs = false;
                     if (!empty($logs)) {