Add ESLint configuration and integrate linting scripts

- Added ESLint as a dependency and created configuration files (.eslintrc.json and .eslintignore).
- Introduced linting scripts in package.json for code quality checks.
- Updated JavaScript files to adhere to ESLint rules, including consistent use of double quotes and improved error handling.
- Removed unused function computeSavedGroup from options.js.
- Ensured proper export of functions in core.js and feedly.api.js.
- Refactored message handling in background.js for better readability and consistency.

Author: olsh

.eslintignore

@@ -0,0 +1,10 @@
+node_modules/
+build/
+test-results/
+logos/
+translations/
+src/styles/
+src/images/
+src/_locales/
+src/sound/
+

.eslintrc.json

@@ -0,0 +1,55 @@
+{
+  "root": true,
+  "env": {
+    "browser": true,
+    "es2021": true
+  },
+  "parserOptions": {
+    "ecmaVersion": 2021,
+    "sourceType": "script"
+  },
+  "extends": ["eslint:recommended"],
+  "globals": {
+    "browser": "readonly",
+    "chrome": "readonly",
+    "$": "readonly",
+    "jQuery": "readonly",
+    "Mustache": "readonly",
+    "DOMPurify": "readonly",
+    "timeago": "readonly",
+    "importScripts": "readonly"
+  },
+  "overrides": [
+    {
+      "files": ["src/scripts/background.js"],
+      "globals": {
+        "appGlobal": "readonly",
+        "getFeeds": "readonly",
+        "getSavedFeeds": "readonly",
+        "markAsRead": "readonly",
+        "toggleSavedFeed": "readonly",
+        "openFeedlyTab": "readonly",
+        "resetCounter": "readonly",
+        "getAccessToken": "readonly"
+      }
+    },
+    {
+      "files": ["Gruntfile.js"],
+      "env": { "node": true }
+    },
+    {
+      "files": ["src/scripts/core.js", "src/scripts/options.js"],
+      "globals": { "FeedlyApiClient": "readonly" }
+    }
+  ],
+  "rules": {
+    "indent": ["error", 4, { "SwitchCase": 1 }],
+    "quotes": ["error", "double", { "avoidEscape": true }],
+    "semi": ["error", "always"],
+    "curly": ["error", "all"],
+    "no-console": "off",
+    "no-unused-vars": ["warn", { "args": "none" }],
+    "no-var": "off",
+    "no-empty": ["error", { "allowEmptyCatch": true }]
+  }
+}

.github/workflows/automerge.yml

@@ -12,10 +12,11 @@ jobs:
             - uses: actions/checkout@v5
             - uses: actions/setup-node@v4
               with:
-                  node-version: "16.x"
+                  node-version: "20.x"
                   cache: "npm"
 
             - run: npm install
+            - run: npm run lint
             - run: npx grunt build --clientId=${{ secrets.FEEDLY_CLIENT_ID }} --clientSecret=${{ secrets.FEEDLY_CLIENT_SECRET }} --browser=${{ matrix.browser }}
 
     automerge:

AGENTS.md

@@ -26,7 +26,12 @@ Load locally: Browser → Extensions → Developer Mode → “Load unpacked”
 - Indentation: 4 spaces; UTF‑8; trim trailing whitespace (enforced by `.editorconfig`).
 - JavaScript: use strict mode; prefer `const/let`, camelCase for variables/functions, PascalCase for constructors; keep filenames lowercase with dashes or dots (e.g., `feedly.api.js`).
 - HTML/CSS: keep inline scripts minimal; reuse existing classes; keep assets under `images/`, `styles/`, `sound/`.
-- No linter is configured; match surrounding style and keep changes focused.
+- ESLint is configured; keep changes focused and fix lint issues as you go.
+
+## Linting
+- Command: `npm run lint` (auto-fix: `npm run lint:fix`).
+- Scope: ESLint across `.js` files; ignores `build/`, `node_modules/`, assets, and locales.
+- Agent rule: after every code change, run `npm run lint` and fix issues before builds or PRs.
 
 ## Testing Guidelines
 - No unit test suite in-repo. Perform manual smoke tests across supported browsers (Chrome, Firefox, Edge/Opera):

Gruntfile.js

@@ -1,23 +1,23 @@
 module.exports = function (grunt) {
     grunt.initConfig({
-        pkg: grunt.file.readJSON('package.json'),
+        pkg: grunt.file.readJSON("package.json"),
         copy: {
             main: {
                 files: [
-                    {expand: true, cwd: '<%= pkg.sourcePath %>/', src: ['**'], dest: '<%= pkg.buildPath %>/'}
+                    {expand: true, cwd: "<%= pkg.sourcePath %>/", src: ["**"], dest: "<%= pkg.buildPath %>/"}
                 ]
             },
             bower: {
                 files: [
-                    {src: '<%= pkg.libPath %>/jquery/dist/jquery.min.js', dest: '<%= pkg.buildPath %>/scripts/jquery.min.js'},
+                    {src: "<%= pkg.libPath %>/jquery/dist/jquery.min.js", dest: "<%= pkg.buildPath %>/scripts/jquery.min.js"},
 
-                    {src: '<%= pkg.libPath %>/webextension-polyfill/dist/browser-polyfill.min.js', dest: '<%= pkg.buildPath %>/scripts/browser-polyfill.min.js'},
+                    {src: "<%= pkg.libPath %>/webextension-polyfill/dist/browser-polyfill.min.js", dest: "<%= pkg.buildPath %>/scripts/browser-polyfill.min.js"},
 
-                    {src: '<%= pkg.libPath %>/mustache/mustache.min.js', dest: '<%= pkg.buildPath %>/scripts/mustache.min.js'},
+                    {src: "<%= pkg.libPath %>/mustache/mustache.min.js", dest: "<%= pkg.buildPath %>/scripts/mustache.min.js"},
 
-                    {src: '<%= pkg.libPath %>/dompurify/dist/purify.min.js', dest: '<%= pkg.buildPath %>/scripts/purify.min.js'},
+                    {src: "<%= pkg.libPath %>/dompurify/dist/purify.min.js", dest: "<%= pkg.buildPath %>/scripts/purify.min.js"},
 
-                    {src: '<%= pkg.libPath %>/timeago.js/dist/timeago.full.min.js', dest: '<%= pkg.buildPath %>/scripts/timeago.full.min.js'},
+                    {src: "<%= pkg.libPath %>/timeago.js/dist/timeago.full.min.js", dest: "<%= pkg.buildPath %>/scripts/timeago.full.min.js"},
                 ]
             }
         },
@@ -84,8 +84,8 @@ module.exports = function (grunt) {
             build: {
                 cwd: "<%= pkg.buildPath %>/",
                 src: ["<%= pkg.buildPath %>/**"],
-                dest: '<%= pkg.buildPath %>/feedly-notifier-' + grunt.option('browser') + '.zip',
-                compression: 'DEFLATE'
+                dest: "<%= pkg.buildPath %>/feedly-notifier-" + grunt.option("browser") + ".zip",
+                compression: "DEFLATE"
             }
         },
         clean: {
@@ -125,10 +125,10 @@ module.exports = function (grunt) {
     });
 
     grunt.loadNpmTasks("grunt-contrib-copy");
-    grunt.loadNpmTasks('grunt-string-replace');
-    grunt.loadNpmTasks('grunt-zip');
-    grunt.loadNpmTasks('grunt-contrib-clean');
-    grunt.loadNpmTasks('grunt-preprocess');
+    grunt.loadNpmTasks("grunt-string-replace");
+    grunt.loadNpmTasks("grunt-zip");
+    grunt.loadNpmTasks("grunt-contrib-clean");
+    grunt.loadNpmTasks("grunt-preprocess");
 
     grunt.registerTask("build", ["clean:pre-build", "copy", "string-replace:keys", "preprocess", "zip", "clean:build"]);
     grunt.registerTask("sandbox", ["copy", "string-replace", "preprocess"]);