tests refactored

Author: olyapka84

tests/conftest.py

@@ -0,0 +1,48 @@
+import pytest
+from django.contrib.auth import get_user_model
+from django.test import Client
+from task_manager.statuses.models import Status
+from task_manager.labels.models import Label
+from task_manager.tasks.models import Task
+
+User = get_user_model()
+
+@pytest.fixture
+def password():
+    return "P@ssw0rd12345"
+
+@pytest.fixture
+def user(db, password):
+    return User.objects.create_user(username="alice", password=password, first_name="Alice", last_name="A")
+
+@pytest.fixture
+def other_user(db, password):
+    return User.objects.create_user(username="bob", password=password, first_name="Bob", last_name="B")
+
+@pytest.fixture
+def auth_client(db, user, password):
+    c = Client()
+    c.login(username=user.username, password=password)
+    return c
+
+@pytest.fixture
+def status_new(db):
+    return Status.objects.create(name="новый")
+
+@pytest.fixture
+def label_bug(db):
+    return Label.objects.create(name="bug")
+
+@pytest.fixture
+def make_task(db, status_new, user):
+    def _make_task(**kwargs):
+        defaults = {
+            "name": "Test task",
+            "description": "",
+            "status": status_new,
+            "author": user,
+            "executor": None,
+        }
+        defaults.update(kwargs)
+        return Task.objects.create(**defaults)
+    return _make_task

tests/test_labels_crud.py

@@ -3,6 +3,8 @@
 
 from task_manager.labels.models import Label
 from task_manager.tasks.models import Task, Status
+pytestmark = pytest.mark.django_db
+
 
 
 @pytest.mark.django_db
@@ -69,4 +71,4 @@ def test_label_delete_when_unused_ok(client, django_user_model):
     url = reverse("labels:delete", args=[label.pk])
     resp = client.post(url)
     assert resp.status_code == 302
-    assert not Label.objects.filter(pk=label.pk).exists()
+    assert not Label.objects.filter(pk=label.pk).exists()

tests/test_statuses_crud.py

@@ -5,6 +5,9 @@
 from task_manager.tasks.models import Task
 import pytest
 from django.contrib.auth import get_user_model
+from django.urls import reverse
+pytestmark = pytest.mark.django_db
+
 User = get_user_model()
 
 
@@ -22,8 +25,8 @@ def auth_client(user):
 
 @pytest.mark.django_db
 def test_login_required(client):
-    r1 = client.get("/statuses/")
-    r2 = client.get("/statuses/create/")
+    r1 = client.get(reverse("statuses:index"))
+    r2 = client.get(reverse("statuses:create"))
     assert r1.status_code in (302, 301)
     assert r2.status_code in (302, 301)
     assert "login" in r1.url
@@ -34,7 +37,7 @@ def test_login_required(client):
 def test_list(auth_client):
     Status.objects.create(name="новый")
     Status.objects.create(name="в работе")
-    resp = auth_client.get("/statuses/")
+    resp = auth_client.get(reverse("statuses:index"))
     assert resp.status_code == 200
     html = resp.content.decode()
     assert "новый" in html
@@ -43,7 +46,7 @@ def test_list(auth_client):
 
 @pytest.mark.django_db
 def test_create(auth_client):
-    resp = auth_client.post("/statuses/create/",
+    resp = auth_client.post(reverse("statuses:create"),
                             data={"name": "на тестировании"})
     assert resp.status_code in (302, 301)
     assert Status.objects.filter(name="на тестировании").exists()
@@ -52,7 +55,7 @@ def test_create(auth_client):
 @pytest.mark.django_db
 def test_update(auth_client):
     st = Status.objects.create(name="черновик")
-    resp = auth_client.post(f"/statuses/{st.pk}/update/",
+    resp = auth_client.post(reverse("statuses:update", args=[st.pk]),
                             data={"name": "завершён"})
     assert resp.status_code in (302, 301)
     st.refresh_from_db()
@@ -62,9 +65,9 @@ def test_update(auth_client):
 @pytest.mark.django_db
 def test_delete(auth_client):
     st = Status.objects.create(name="временный")
-    get_resp = auth_client.get(f"/statuses/{st.pk}/delete/")
+    get_resp = auth_client.get(reverse("statuses:delete", args=[st.pk]))
     assert get_resp.status_code == 200
-    post_resp = auth_client.post(f"/statuses/{st.pk}/delete/")
+    post_resp = auth_client.post(reverse("statuses:delete", args=[st.pk]))
     assert post_resp.status_code in (302, 301)
     assert not Status.objects.filter(pk=st.pk).exists()
 
@@ -82,4 +85,4 @@ def test_cannot_delete_status_in_use(django_user_model):
     )
 
     with pytest.raises(ProtectedError):
-        status.delete()
+        status.delete()

tests/test_tasks_crud.py

@@ -1,116 +1,164 @@
-from task_manager.statuses.models import Status
-from task_manager.tasks.models import Task
 import pytest
 from django.contrib.auth import get_user_model
+from django.test import Client
+from django.urls import reverse
+from task_manager.tasks.models import Task
+from task_manager.statuses.models import Status
+
 User = get_user_model()
 
 
+@pytest.fixture
+def status_new(db):
+    return Status.objects.create(name="новый")
+
+
 @pytest.fixture
 def users(db):
-    pwd = "p12345678"
-    u1 = User.objects.create_user(username="user1", password=pwd)
-    u2 = User.objects.create_user(username="user2", password=pwd)
-    return {"u1": u1, "u2": u2, "pwd": pwd}
+    password = "P@ssw0rd12345"
+    u1 = User.objects.create_user(
+        username="alice", password=password, first_name="Alice", last_name="A"
+    )
+    u2 = User.objects.create_user(
+        username="bob", password=password, first_name="Bob", last_name="B"
+    )
+    return {"alice": u1, "bob": u2, "password": password}
 
 
 @pytest.fixture
 def auth_client(users):
-    from django.test import Client
     c = Client()
-    c.login(username="user1", password=users["pwd"])
+    c.login(username="alice", password=users["password"])
     return c
 
 
-@pytest.fixture
-def status_new(db):
-    return Status.objects.create(name="новый")
+@pytest.mark.django_db
+def test_users_list_is_public(client, users):
+    resp = client.get(reverse("list", current_app="users"))
+    assert resp.status_code == 200
+    html = resp.content.decode()
+    assert "alice" in html
+    assert "bob" in html
 
 
 @pytest.mark.django_db
-def test_login_required(client):
-    r = client.get("/tasks/")
+def test_registration_get(client):
+    r = client.get(reverse("create", current_app="users"))
+    assert r.status_code == 200
+    html = r.content.decode()
+    assert 'name="username"' in html
+    assert 'name="password1"' in html
+    assert 'name="password2"' in html
+
+
+@pytest.mark.django_db
+def test_registration_post_creates_user(client):
+    data = {
+        "username": "charlie",
+        "first_name": "Charlie",
+        "last_name": "C",
+        "password1": "XyZ12345!xyZ",
+        "password2": "XyZ12345!xyZ",
+    }
+    r = client.post(reverse("create", current_app="users"), data=data)
     assert r.status_code in (302, 301)
+    assert User.objects.filter(username="charlie").exists()
 
 
 @pytest.mark.django_db
-def test_list(auth_client, users, status_new):
-    Task.objects.create(name="Тестовая задача", description="Описание",
-                        status=status_new, author=users["u1"])
-    Task.objects.create(name="Вторая", description="Ещё одна",
-                        status=status_new, author=users["u1"])
-    r = auth_client.get("/tasks/")
-    assert r.status_code == 200
-    html = r.content.decode()
-    assert "Тестовая задача" in html
-    assert "Вторая" in html
+def test_update_requires_auth_redirects(client, users):
+    url = reverse("update", args=[users["alice"].pk], current_app="users")
+    r = client.get(url)
+    assert r.status_code in (302, 301)
+    assert reverse("login") in r.url
+    assert f"next={url}" in r.url
 
 
 @pytest.mark.django_db
-def test_create(auth_client, users, status_new):
-    resp = auth_client.post("/tasks/create/", data={
-        "name": "Новая задача",
-        "description": "Что-то сделать",
-        "status": status_new.pk,
-        "executor": users["u2"].pk,
-    })
-    assert resp.status_code in (302, 301)
-    assert Task.objects.filter(name="Новая задача",
-                               status=status_new,
-                               author=users["u1"]).exists()
+def test_user_can_update_self(auth_client, users):
+    url = reverse("update", args=[users["alice"].pk], current_app="users")
+    r_get = auth_client.get(url)
+    assert r_get.status_code == 200
+
+    r_post = auth_client.post(
+        url,
+        data={"username": "alice_new", "first_name": "Al", "last_name": "A"},
+    )
+    assert r_post.status_code in (302, 301)
+
+    users["alice"].refresh_from_db()
+    assert users["alice"].username == "alice_new"
+    assert users["alice"].first_name == "Al"
 
 
 @pytest.mark.django_db
-def test_update(auth_client, users, status_new):
-    t = Task.objects.create(name="Черновик", description="Описание",
-                            status=status_new, author=users["u1"])
-    resp = auth_client.post(f"/tasks/{t.pk}/update/", data={
-        "name": "Изменено",
-        "description": "Новое описание",
-        "status": status_new.pk,
-        "executor": users["u2"].pk,
-    })
-    assert resp.status_code in (302, 301)
-    t.refresh_from_db()
-    assert t.name == "Изменено"
-    assert t.description == "Новое описание"
-    assert t.executor == users["u2"]
+def test_user_cannot_update_other(auth_client, users):
+    url = reverse("update", args=[users["bob"].pk], current_app="users")
+    r = auth_client.post(url, data={"username": "bob_hacked"})
+    assert r.status_code in (302, 403, 404)
+    users["bob"].refresh_from_db()
+    assert users["bob"].username == "bob"
 
 
 @pytest.mark.django_db
-def test_view(auth_client, users, status_new):
-    t = Task.objects.create(name="Посмотреть", description="Детали",
-                            status=status_new, author=users["u1"])
-    r = auth_client.get(f"/tasks/{t.pk}/")
-    assert r.status_code == 200
-    html = r.content.decode()
-    assert "Посмотреть" in html
-    assert "Детали" in html
+def test_delete_requires_auth_redirects(client, users):
+    url = reverse("delete", args=[users["alice"].pk], current_app="users")
+    r = client.get(url)
+    assert r.status_code in (302, 301)
+    assert reverse("login") in r.url
 
 
 @pytest.mark.django_db
-def test_delete(auth_client, users, status_new):
-    t = Task.objects.create(name="Удалить", description="Ненужная",
-                            status=status_new, author=users["u1"])
-    r_get = auth_client.get(f"/tasks/{t.pk}/delete/")
+def test_user_can_delete_self(users):
+    c = Client()
+    c.login(username="bob", password=users["password"])
+    url = reverse("delete", args=[users["bob"].pk], current_app="users")
+    r_get = c.get(url)
     assert r_get.status_code == 200
-    r_post = auth_client.post(f"/tasks/{t.pk}/delete/")
+    r_post = c.post(url)
     assert r_post.status_code in (302, 301)
-    assert not Task.objects.filter(pk=t.pk).exists()
+    assert not User.objects.filter(pk=users["bob"].pk).exists()
+
+
+@pytest.mark.django_db
+def test_user_cannot_delete_other(auth_client, users):
+    url = reverse("delete", args=[users["bob"].pk], current_app="users")
+    r = auth_client.post(url)
+    assert r.status_code in (302, 403, 404)
+    assert User.objects.filter(pk=users["bob"].pk).exists()
 
 
 @pytest.mark.django_db
 def test_only_author_can_delete(auth_client, users, status_new):
     t = Task.objects.create(
-        name="Чужая задача", description="...",
-        status=status_new, author=users["u2"]
+        name="Чужая задача",
+        description="...",
+        status=status_new,
+        author=users["bob"],
     )
-    r = auth_client.post(f"/tasks/{t.pk}/delete/")
+    r = auth_client.post(reverse("tasks:delete", args=[t.pk]))
     assert r.status_code in (302, 301)
     assert Task.objects.filter(pk=t.pk).exists()
 
-    from django.test import Client
     c = Client()
-    c.login(username="user2", password=users["pwd"])
-    r2 = c.post(f"/tasks/{t.pk}/delete/")
+    c.login(username="bob", password=users["password"])
+    r2 = c.post(reverse("tasks:delete", args=[t.pk]))
     assert r2.status_code in (302, 301)
     assert not Task.objects.filter(pk=t.pk).exists()
+
+
+@pytest.mark.django_db
+def test_user_with_tasks_cannot_be_deleted(users, status_new):
+    Task.objects.create(
+        name="Тестовая",
+        description="Проверка",
+        status=status_new,
+        author=users["bob"],
+    )
+
+    c = Client()
+    c.login(username="bob", password=users["password"])
+    url = reverse("delete", args=[users["bob"].pk], current_app="users")
+    r = c.post(url)
+    assert r.status_code in (302, 301)
+    assert User.objects.filter(pk=users["bob"].pk).exists()