-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Description
page.name is currently used for populating the id field:
Lines 40 to 44 in e601fea
| indexer << page.data.merge({ | |
| id: page.name, | |
| url: page.url, | |
| text: nokogiri_doc.xpath("//article//text()").to_s.gsub(/\s+/, " ") | |
| }) |
However, there's no guarantee that name contains a defined value, and Elasticsearch will complain if it doesn't.
Why don't we use page.url instead, which is unique enough for being used as an ID (definitely more than name) and is guaranteed to be always defined?
asbjornu
Metadata
Metadata
Assignees
Labels
No labels