Skip to content

rotation and affine should be 2D list of numbers? #11

@will-moore

Description

@will-moore

The spec for "rotation" at https://ngff-spec.readthedocs.io/en/latest/specification.html#rotation states "The matrix MUST be stored as a 2D array either as json or in a zarr array".
Same is true for Affine.

However, the schema at


has the rotation property as a list of numbers:

            "rotation": {
              "type": "array",
              "items": {
                "type": "number"
              }
            },

Whereas for Affine it supports a flat list OR a nested 2D list:

https://github.com/ome/ngff-spec/blob/9e65955df1b840bf955ca328b859722870807ae4/schemas/coordinate_transformation.schema#L240C32-L240C47

The schema above is currently causing validation failures if I have a 2D list for "rotation".

In the table at https://ngff-spec.readthedocs.io/en/latest/specification.html#coordinatetransformations-metadata the rotation description doesn't say that a 2D array should be used, and in the affine description of the table it says "affine transformation matrix stored as a flat array" which contradicts the spec above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions