Skip to content

Commit a44e9f5

Browse files
chrispaulintheoryomnibrain
authored andcommitted
fix: correct fret label position when fretLabelPosition is LEFT
Alignment.RIGHT was passing 'right' as SVG text-anchor which is invalid. Map it to 'end' instead. Also remove the 1/sizeMultiplier hack that was compensating for the broken alignment. Fixes #126
1 parent 2a9d61f commit a44e9f5

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/renderer/svgjs/svg-js-renderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class SvgJsRenderer extends Renderer {
8585
.font({
8686
family: fontFamily,
8787
size: fontSize,
88-
anchor: alignment,
88+
anchor: alignment === Alignment.RIGHT ? 'end' : alignment,
8989
'dominant-baseline': 'central',
9090
})
9191
.fill(color)
@@ -97,7 +97,7 @@ export class SvgJsRenderer extends Renderer {
9797
.font({
9898
family: fontFamily,
9999
size: fontSize,
100-
anchor: alignment,
100+
anchor: alignment === Alignment.RIGHT ? 'end' : alignment,
101101
})
102102
.fill(color)
103103
.addClass(Renderer.toClassName(classes))

src/svguitar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -814,7 +814,7 @@ export class SVGuitarChord {
814814
} else {
815815
const svgText = this.renderer.text(
816816
text,
817-
1 / sizeMultiplier + startX - padding,
817+
startX - padding,
818818
y,
819819
size * sizeMultiplier,
820820
color,

0 commit comments

Comments
 (0)