TextEditor sample: toolbarItemsForDocument: unused parameter?

[memmons]

The AppController's toolbarItemsForDocument: parameter is not being used in the TextEditor sample. In addition the following comment appears in it:

// Cache document toolbar items. These must *only* target the given object (not the document) 
   so that we can reuse them.

Is the OUIDocument parameter legacy code that wouldn't typically be used or is the TextEditor samle a special case where it's not needed?

[tjw]

Yeah, that comment seems pretty unclear. It would be better written as "Since we are caching these toolbar items, the must target the receiver and not the passed in document."

Looking through our apps, I don't see anywhere that we are currently making use of the document argument. I don't recall off hand if we ever did (say, to return a different set of toolbar items for different document types) or whether we were being 'helpful' by passing it.

Caching these toolbar items seems like a dubious optimization, really.