Add first name search field to find owners form#88
Closed
meysholdt wants to merge 1 commit into
Closed
Conversation
The find owners form only searched by last name. This adds a first name field so users can narrow results when multiple owners share a surname. - Add findByLastNameStartingWithAndFirstNameStartingWith to OwnerRepository - Update OwnerController to pass both firstName and lastName to the query - Add firstName input to findOwners.html template - Preserve both search params in ownersList.html pagination links - Add tests for first name and combined first+last name search Closes CX-216 Co-authored-by: Ona <no-reply@ona.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The find owners form only searched by last name. This adds a first name field so users can narrow results when multiple owners share a surname.
Closes CX-216
Changes
findByLastNameStartingWithAndFirstNameStartingWithquery methodfirstNameandlastNameto the repository query; forward both values to the pagination modellastNameandfirstNamequery params in pagination linksTesting
All 59 tests pass (including 2 new test cases for first name search).