Improve build and reduce warnings

Author: oneMillionWorlds

build.gradle

@@ -39,4 +39,11 @@ tasks.register('prepareCentralBundle') {
     group = 'publishing'
     description = 'Stages and zips artifacts ready for Central Publisher Portal upload (no network).'
     dependsOn 'zipCentralPortalBundle'
+}
+
+subprojects {
+    tasks.withType(Javadoc).configureEach {
+        // Prevent the build complaining there isn't an @param on every singple parameter
+        options.addStringOption('Xdoclint:none', '-quiet')
+    }
 }

tamarin-core/src/main/java/com/onemillionworlds/tamarin/vrhands/functions/handmenu/HandRingMenuFunction.java

@@ -34,15 +34,14 @@
  * The menu remains open for as long as the digital action remains held. When the action is released where the hand is
  * controls what is selected (if anything)
  */
+@SuppressWarnings("unused")
 public class HandRingMenuFunction<T> implements BoundHandFunction{
 
     private final List<MenuItem<T>> topLevelMenuItems;
     private List<MenuBranch<T>> currentOpenPath = List.of();
 
     private final Consumer<Optional<T>> selectionConsumer;
 
-    ActionHandle digitalActionToOpenMenu;
-
     private BoundHand boundHand;
     private XrActionBaseAppState actionBasedOpenVrState;
     private XrBaseAppState vrAppState;
@@ -93,6 +92,8 @@ public class HandRingMenuFunction<T> implements BoundHandFunction{
      */
     Map<Node, Supplier<Spatial>> dynamicGeometrySuppliers = new HashMap<>();
 
+    private final Supplier<Boolean> shouldBeOpenSupplier;
+
     /**
      * @param menuItems               the tree of menu items
      * @param selectionConsumer       when an item is selected it is given to this consumer
@@ -101,9 +102,14 @@ public class HandRingMenuFunction<T> implements BoundHandFunction{
     public HandRingMenuFunction(List<MenuItem<T>> menuItems, Consumer<Optional<T>> selectionConsumer, ActionHandle digitalActionToOpenMenu){
         this.topLevelMenuItems = menuItems;
         this.selectionConsumer = selectionConsumer;
-        this.digitalActionToOpenMenu = digitalActionToOpenMenu;
-    }
+        this.shouldBeOpenSupplier = () -> this.actionBasedOpenVrState.getBooleanActionState(digitalActionToOpenMenu, boundHand.getHandSide().restrictToInputString).getState();
 
+    }
+    public HandRingMenuFunction(List<MenuItem<T>> menuItems, Consumer<Optional<T>> selectionConsumer, Supplier<Boolean> shouldBeOpenSupplier){
+        this.topLevelMenuItems = menuItems;
+        this.selectionConsumer = selectionConsumer;
+        this.shouldBeOpenSupplier = shouldBeOpenSupplier;
+    }
 
     @Override
     public void onBind(BoundHand boundHand, AppStateManager stateManager){
@@ -124,12 +130,12 @@ public void onUnbind(BoundHand boundHand, AppStateManager stateManager){
 
     @Override
     public void update(float timeSlice, BoundHand boundHand, AppStateManager stateManager){
-        BooleanActionState menuButtonPressed = actionBasedOpenVrState.getBooleanActionState(digitalActionToOpenMenu, boundHand.getHandSide().restrictToInputString);
-        if(menuButtonPressed.getState() && !this.menuOpen){
+        boolean menuButtonPressed = shouldBeOpenSupplier.get();
+        if(menuButtonPressed && !this.menuOpen){
             openMenu();
         }
 
-        if(!menuButtonPressed.getState() && this.menuOpen){
+        if(!menuButtonPressed && this.menuOpen){
             closeMenuAndSelect();
         }
 

tamarin-core/src/main/java/com/onemillionworlds/tamarin/vrhands/grabbing/AbstractGrabControl.java

@@ -18,6 +18,7 @@
  * </p>
  * Extend this class to get access to onGrab and onRelease, make sure to call super
  */
+@SuppressWarnings("unused")
 public abstract class AbstractGrabControl extends AbstractControl{