Skip to content

Commit 19a3a0f

Browse files
authored
Merge pull request #2442 from onevcat/fix/xcode-26-macos
Fix crash on setting indicator on macOS 26
2 parents 43cc4a1 + ef7d47d commit 19a3a0f

File tree

5 files changed

+30
-29
lines changed

5 files changed

+30
-29
lines changed

.github/workflows/build.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jobs:
2727
'watchOS Simulator,name=Apple Watch Series 9 (41mm),OS=10.5'
2828
]
2929
xcode: [
30-
'15.2',
31-
'15.3',
3230
'16.0',
3331
'16.1',
32+
'16.2',
33+
'16.3',
3434
]
3535
steps:
3636
- uses: actions/checkout@v4

.github/workflows/test.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ jobs:
2222
matrix:
2323
destination: [
2424
'macOS',
25-
'iOS Simulator,name=iPhone 15,OS=17.5',
26-
'tvOS Simulator,name=Apple TV,OS=17.5',
27-
'watchOS Simulator,name=Apple Watch Series 9 (41mm),OS=10.5'
25+
'iOS Simulator,name=iPhone 16,OS=18.5',
26+
'tvOS Simulator,name=Apple TV,OS=18.5',
27+
'watchOS Simulator,name=Apple Watch Series 10 (42mm),OS=11.5'
2828
]
2929
xcode: [
30-
'15.4',
31-
'16.2',
30+
'16.4',
31+
'26.0.1',
3232
]
3333
steps:
3434
- uses: actions/checkout@v4

Gemfile.lock

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ GEM
55
base64
66
nkf
77
rexml
8-
activesupport (7.2.2.1)
8+
activesupport (7.2.2.2)
99
base64
1010
benchmark (>= 0.3)
1111
bigdecimal
@@ -25,27 +25,28 @@ GEM
2525
artifactory (3.0.17)
2626
atomos (0.1.3)
2727
aws-eventstream (1.4.0)
28-
aws-partitions (1.1118.0)
29-
aws-sdk-core (3.226.0)
28+
aws-partitions (1.1168.0)
29+
aws-sdk-core (3.233.0)
3030
aws-eventstream (~> 1, >= 1.3.0)
3131
aws-partitions (~> 1, >= 1.992.0)
3232
aws-sigv4 (~> 1.9)
3333
base64
34+
bigdecimal
3435
jmespath (~> 1, >= 1.6.1)
3536
logger
36-
aws-sdk-kms (1.105.0)
37-
aws-sdk-core (~> 3, >= 3.225.0)
37+
aws-sdk-kms (1.113.0)
38+
aws-sdk-core (~> 3, >= 3.231.0)
3839
aws-sigv4 (~> 1.5)
39-
aws-sdk-s3 (1.190.0)
40-
aws-sdk-core (~> 3, >= 3.225.0)
40+
aws-sdk-s3 (1.199.1)
41+
aws-sdk-core (~> 3, >= 3.231.0)
4142
aws-sdk-kms (~> 1)
4243
aws-sigv4 (~> 1.5)
4344
aws-sigv4 (1.12.1)
4445
aws-eventstream (~> 1, >= 1.0.2)
4546
babosa (1.0.4)
4647
base64 (0.3.0)
4748
benchmark (0.4.1)
48-
bigdecimal (3.2.2)
49+
bigdecimal (3.2.3)
4950
claide (1.1.0)
5051
cocoapods (1.16.2)
5152
addressable (~> 2.8)
@@ -89,7 +90,7 @@ GEM
8990
commander (4.6.0)
9091
highline (~> 2.0.0)
9192
concurrent-ruby (1.3.5)
92-
connection_pool (2.5.3)
93+
connection_pool (2.5.4)
9394
declarative (0.0.20)
9495
digest-crc (0.7.0)
9596
rake (>= 12.0.0, < 14.0.0)
@@ -98,7 +99,7 @@ GEM
9899
drb (2.2.3)
99100
emoji_regex (3.2.3)
100101
escape (0.0.4)
101-
ethon (0.16.0)
102+
ethon (0.17.0)
102103
ffi (>= 1.15.0)
103104
excon (0.112.0)
104105
faraday (1.10.4)
@@ -222,15 +223,15 @@ GEM
222223
i18n (1.14.7)
223224
concurrent-ruby (~> 1.0)
224225
jmespath (1.6.2)
225-
json (2.12.2)
226-
jwt (2.10.1)
226+
json (2.15.0)
227+
jwt (2.10.2)
227228
base64
228229
logger (1.7.0)
229230
mini_magick (4.13.2)
230231
mini_mime (1.1.5)
231232
minitest (5.25.5)
232233
molinillo (0.8.0)
233-
multi_json (1.15.0)
234+
multi_json (1.17.0)
234235
multipart-post (2.4.1)
235236
mutex_m (0.3.0)
236237
nanaimo (0.4.0)
@@ -248,17 +249,17 @@ GEM
248249
trailblazer-option (>= 0.1.1, < 0.2.0)
249250
uber (< 0.2.0)
250251
retriable (3.1.2)
251-
rexml (3.4.2)
252+
rexml (3.4.4)
252253
rouge (3.28.0)
253254
ruby-macho (2.5.1)
254255
ruby2_keywords (0.0.5)
255256
rubyzip (2.4.1)
256257
securerandom (0.4.1)
257258
security (0.1.5)
258-
signet (0.20.0)
259+
signet (0.21.0)
259260
addressable (~> 2.8)
260261
faraday (>= 0.17.5, < 3.a)
261-
jwt (>= 1.5, < 3.0)
262+
jwt (>= 1.5, < 4.0)
262263
multi_json (~> 1.10)
263264
simctl (1.6.10)
264265
CFPropertyList

Sources/Views/Indicator.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ final class ActivityIndicator: Indicator {
152152
init() {
153153
#if os(macOS)
154154
activityIndicatorView = NSProgressIndicator(frame: CGRect(x: 0, y: 0, width: 16, height: 16))
155-
activityIndicatorView.controlSize = .small
155+
activityIndicatorView.controlSize = .regular
156156
activityIndicatorView.style = .spinning
157157
#else
158158
let indicatorStyle: UIActivityIndicatorView.Style

fastlane/Fastfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ platform :ios do
66
desc "Runs all the tests"
77
lane :tests do
88
test(destination: "platform=macOS")
9-
test(destination: "platform=iOS Simulator,name=iPhone 15,OS=17.5")
10-
test(destination: "platform=tvOS Simulator,name=Apple TV,OS=17.5")
11-
build(destination: "platform=watchOS Simulator,name=Apple Watch Series 9 (41mm),OS=10.5")
9+
test(destination: "platform=iOS Simulator,name=iPhone 16,OS=18.5")
10+
test(destination: "platform=tvOS Simulator,name=Apple TV,OS=18.5")
11+
build(destination: "platform=watchOS Simulator,name=Apple Watch Series 10 (42mm),OS=11.5")
1212
end
1313

1414
lane :test_ci do
@@ -93,7 +93,7 @@ platform :ios do
9393
lane :xcframework do |options|
9494
version = options[:version]
9595
swift_version = options[:swift_version] || "5.0"
96-
xcode_version = options[:xcode_version] || "16.4"
96+
xcode_version = options[:xcode_version] || "26.0.1"
9797

9898
xcodes(version: xcode_version, select_for_current_build_only: true)
9999
FileUtils.rm_rf '../build'
@@ -166,7 +166,7 @@ platform :ios do
166166
end
167167

168168
before_all do |lane|
169-
xcode_version = ENV["XCODE_VERSION"] || "16.4"
169+
xcode_version = ENV["XCODE_VERSION"] || "26.0.1"
170170
xcodes(version: xcode_version, select_for_current_build_only: true)
171171
end
172172

0 commit comments

Comments
 (0)