Carthage prebuilt binary support

[olejnjak]

Hi, I was wondering as long as GitHub releases contain a prebuilt XCFramework, is it intentional that binaries are not named with .xcframework.zip suffix to indicate compatibility with Carthage?

It would also prevent or at least reduce number of signing issues like this one Carthage/Carthage#3383

Thanks in advance :-)

[onevcat]

Carthage is basically dead and not even considered when releasing that.

is it intentional that binaries are not named with .xcframework.zip suffix to indicate compatibility with Carthage

I wasn't aware of this convention, so I'll explore possible steps. However, renaming the zip file might break existing integrations used by other developers, so we should proceed cautiously (or likely not do that). I wonder if Carthage allows specifying the zip name during the setup process. Relying on a fixed and non-enforced name seems somewhat unreliable.

[olejnjak]

I wonder if Carthage allows specifying the zip name during the setup process.

I don't think so, the filter just looks for .xcframework without the zip extension.

renaming the zip file might break existing integrations used by other developers

That is true, but can be solved easily by duplicating the asset, so I don't think that is a problem 🤔

[onevcat]

Good. Thanks for the information.

solved easily by duplicating the asset, so I don't think that is a problem.

I don’t like this idea because providing the same thing twice creates confusion. Instead, let’s add xcframework to the file name. I assume any breaking integration should be easy to fix by simply updating the file name.

However, it surprises me that Carthage doesn’t offer an option to specify a file name.

[olejnjak]

If I may just one more note - I've seen you added iOS only XCFramework in 8.2.0...in this case Kingfisher.xcframework.zip and Kingsfisher-iOS.zip should be published, naming it with version (Kingfisher-8.2.0.xcframework.zip) is still okay ;-)

[onevcat]

@olejnjak Thanks for the note. But I am not sure I am 100% understand you.

With #2361, the new file names would be something like:

// All platform
Kingfisher-8.3.0.xcframework.zip

// iOS-only
Kingfisher-iOS-8.3.0.xcframework.zip

Do you think that is fine? (Not sure which one Carthage would pick in this case...)

[olejnjak]

I will rather try that as I am not certain when looking at the source code.