You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Phase 7 final checks (10 manual-test agents) surfaced 4 issues that
needed pre-merge resolution:
B1 — security-best-practices.mdx residual 'account' references (M1).
F-006 fixed the design-patterns.mdx `account` vs `signer` mismatch
but missed the same pattern in security-best-practices.mdx — three
references on lines 89, 103, 113 were still using `account.capabilities.*`
while line 115 (and the surrounding prose) used `signer`. All three
edits switched to `signer` for consistency with the publish call.
B2 — fumadocs DocsLayout grid bug on mobile/tablet (M8).
The F-002 a11y fix wrapped DocsLayout's children in '<main>' for the
landmark-one-main audit. That broke fumadocs' CSS Grid: the grid uses
named areas ('[grid-area:main]') on the article, which expects to be
a direct child of DocsLayout. The wrapper made the article a grandchild,
so the grid forced 'grid-template-columns: 872px 0px 0px 0px 0px' on
every viewport — content clipped at 320, 375, and 768 widths on docs
pages (10/60 fail combos).
Fix: add 'style={{ display: 'contents' }}' to the <main> element. The
landmark stays for a11y/Lighthouse but the article reverts to being a
direct grid child for layout purposes.
B3 — search bias overcorrection (M5 exhaustive).
Earlier 'biasLocalFirst' (3f0ada5) put ALL locals before externals to
fix a federation-pushed-out-local regression from F-012. M5 found this
overcorrected: weak-match local pages (e.g. /docs/ai-tools/skills, which
mentions many Flow concepts in passing) outranked strongly-relevant
external developers.flow.com pages. 6/7 federation queries failed.
Tried a milder 'bubble first local to position 0' — same root cause,
same failure.
Fix: remove the bias entirely. Trust Orama's term-frequency scoring;
federation queries that match developers.flow.com better naturally
rank higher. Tradeoffs documented: 2 local-targeting queries now
surface external pages instead. Proper field-weight tuning is tracked
as #296.
M10 polish — three issues:
- pageUrl/docPath props leaking from <DocsPage> to a DOM element
(every docs page logged 2 React DOM-prop warnings). Destructure
custom props before {...spread}.
- frameborder/allowfullscreen JSX casing in 3 tutorial files (first-steps,
hello-world, resources) — JSX requires camelCase frameBorder /
allowFullScreen.
Verified: types:check clean, build clean, search test shows federation
works for 5+ queries, no DOM-prop warnings expected from the fixed
files.
Refs: pr285-evaluation/eval/M{1,5,7,8,10}*.md
0 commit comments