Remove cadence_lint MCP tool — available via flow cadence lint CLI

Author: peterargue

internal/mcp/lint_test.go

@@ -62,7 +62,6 @@ Available tools:
   cadence_completion     Get completions at a position
   get_contract_source    Fetch on-chain contract manifest
   get_contract_code      Fetch contract source code from an address
-  cadence_lint           Run Cadence lint analyzers (AST-based)
   cadence_code_review    Review Cadence code for common issues
   cadence_execute_script Execute a read-only Cadence script on-chain`,
 	Run: runMCP,

internal/mcp/mcp.go

@@ -29,13 +29,10 @@ import (
 	mcplib "github.com/mark3labs/mcp-go/mcp"
 	mcpserver "github.com/mark3labs/mcp-go/server"
 	"github.com/onflow/cadence"
-	"github.com/onflow/cadence/tools/analysis"
 	flow "github.com/onflow/flow-go-sdk"
 
 	"github.com/onflow/flowkit/v2"
 	"github.com/onflow/flowkit/v2/arguments"
-
-	cadenceLinter "github.com/onflow/flow-cli/internal/cadence"
 )
 
 // mcpContext holds shared dependencies for all MCP tool handlers.
@@ -132,14 +129,6 @@ func registerTools(s *mcpserver.MCPServer, mctx *mcpContext) {
 		mctx.getContractCode,
 	)
 
-	s.AddTool(
-		mcplib.NewTool("cadence_lint",
-			mcplib.WithDescription("Run Cadence lint analyzers on code. Detects common issues like unnecessary casts, deprecated patterns, unused variables, and more using AST-based analysis."),
-			mcplib.WithString("code", mcplib.Required(), mcplib.Description("Cadence source code to lint")),
-		),
-		mctx.cadenceLint,
-	)
-
 	s.AddTool(
 		mcplib.NewTool("cadence_code_review",
 			mcplib.WithDescription("Review Cadence code for common issues and anti-patterns."),
@@ -372,19 +361,6 @@ func (m *mcpContext) getContractCode(ctx context.Context, req mcplib.CallToolReq
 	return mcplib.NewToolResultText(b.String()), nil
 }
 
-func (m *mcpContext) cadenceLint(_ context.Context, req mcplib.CallToolRequest) (*mcplib.CallToolResult, error) {
-	code, err := resolveCode(req)
-	if err != nil {
-		return mcplib.NewToolResultError(err.Error()), nil
-	}
-
-	diagnostics, err := cadenceLinter.LintCode(code, m.state)
-	if err != nil {
-		return mcplib.NewToolResultError(fmt.Sprintf("lint failed: %v", err)), nil
-	}
-	return mcplib.NewToolResultText(formatLintDiagnostics(diagnostics)), nil
-}
-
 func (m *mcpContext) cadenceCodeReview(_ context.Context, req mcplib.CallToolRequest) (*mcplib.CallToolResult, error) {
 	code, err := resolveCode(req)
 	if err != nil {
@@ -439,31 +415,3 @@ func (m *mcpContext) cadenceExecuteScript(ctx context.Context, req mcplib.CallTo
 	return mcplib.NewToolResultText(val.String()), nil
 }
 
-// formatLintDiagnostics formats analysis diagnostics as human-readable text.
-func formatLintDiagnostics(diagnostics []analysis.Diagnostic) string {
-	if len(diagnostics) == 0 {
-		return "Lint passed — no issues found."
-	}
-
-	var b strings.Builder
-	numErrors := 0
-	numWarnings := 0
-	for _, d := range diagnostics {
-		sev := "warning"
-		if d.Category == "error" || d.Category == "semantic-error" || d.Category == "syntax-error" {
-			sev = "error"
-			numErrors++
-		} else {
-			numWarnings++
-		}
-		fmt.Fprintf(&b, "[%s] line %d:%d (%s): %s\n",
-			sev,
-			d.Range.StartPos.Line,
-			d.Range.StartPos.Column,
-			d.Category,
-			d.Message,
-		)
-	}
-	fmt.Fprintf(&b, "\n%d error(s), %d warning(s)\n", numErrors, numWarnings)
-	return b.String()
-}