fix ci

Author: holyfuchs

solidity/.gas-snapshot

@@ -1,102 +1,103 @@
 FCMVaultFactoryTest:test_ComputeAddress_DifferentSaltDifferentAddress() (gas: 92989)
-FCMVaultFactoryTest:test_ComputeAddress_MatchesDeployed() (gas: 4415670)
-FCMVaultFactoryTest:test_CreateVault_DeploysVault() (gas: 4391459)
-FCMVaultFactoryTest:test_CreateVault_EmitsEvent() (gas: 4418065)
-FCMVaultFactoryTest:test_CreateVault_SameSaltReverts() (gas: 1040566452)
-FCMVaultTest:test_AdminCanGrantRole() (gas: 42834)
-FCMVaultTest:test_AdminCanRevokeRole() (gas: 33308)
-FCMVaultTest:test_DepositRevertsForNonAllowlistedReceiver() (gas: 307268)
-FCMVaultTest:test_Deposit_DepositDoesNotRebalanceProtocol() (gas: 586622)
-FCMVaultTest:test_Deposit_FirstDepositMintsShares() (gas: 353500)
-FCMVaultTest:test_Deposit_LandsAtBandMidpoint() (gas: 363729)
-FCMVaultTest:test_Deposit_NavRoundsToOriginalAssets() (gas: 360081)
-FCMVaultTest:test_Deposit_NoBorrowWhenPositionUnhealthy() (gas: 491778)
+FCMVaultFactoryTest:test_ComputeAddress_MatchesDeployed() (gas: 4415270)
+FCMVaultFactoryTest:test_CreateVault_DeploysVault() (gas: 4391059)
+FCMVaultFactoryTest:test_CreateVault_EmitsEvent() (gas: 4417665)
+FCMVaultFactoryTest:test_CreateVault_SameSaltReverts() (gas: 1040566438)
+FCMVaultTest:test_AdminCanGrantRole() (gas: 42856)
+FCMVaultTest:test_AdminCanRevokeRole() (gas: 33325)
+FCMVaultTest:test_DepositRevertsForNonAllowlistedReceiver() (gas: 307286)
+FCMVaultTest:test_Deposit_DepositDoesNotRebalanceProtocol() (gas: 586638)
+FCMVaultTest:test_Deposit_FirstDepositMintsShares() (gas: 353517)
+FCMVaultTest:test_Deposit_LandsAtBandMidpoint() (gas: 363746)
+FCMVaultTest:test_Deposit_NavRoundsToOriginalAssets() (gas: 360102)
+FCMVaultTest:test_Deposit_NoBorrowWhenPositionUnhealthy() (gas: 491796)
 FCMVaultTest:test_Deposit_PullsCollateralAndBorrowsDebt() (gas: 355451)
-FCMVaultTest:test_Deposit_RevertsOnZeroApproval() (gas: 127495)
-FCMVaultTest:test_Deposit_RevertsWhenUnderwaterWithHolders() (gas: 489876)
-FCMVaultTest:test_Deposit_TwoDepositorsProRata() (gas: 526881)
-FCMVaultTest:test_Fees_AccruePermissionlessSettersGated() (gas: 372672)
-FCMVaultTest:test_Fees_AccruesOnRebalance() (gas: 566841)
-FCMVaultTest:test_Fees_AccruesOnRedeemAndDeAllowlistDoesNotBrick() (gas: 704448)
-FCMVaultTest:test_Fees_AccruesOnRedeemInKind() (gas: 667064)
-FCMVaultTest:test_Fees_CombinedAccrual() (gas: 568713)
-FCMVaultTest:test_Fees_GrossUpDeliversTrueRate() (gas: 530794)
-FCMVaultTest:test_Fees_ManagementAccrual() (gas: 530841)
-FCMVaultTest:test_Fees_ManagementClampedAtOneYear() (gas: 530710)
-FCMVaultTest:test_Fees_NoAccrualAfterRecovered() (gas: 636909)
-FCMVaultTest:test_Fees_NoPerfInDrawdown() (gas: 553551)
-FCMVaultTest:test_Fees_NoPerfOnFirstDeposit() (gas: 478884)
-FCMVaultTest:test_Fees_NoRetroactiveChargeOnEnable() (gas: 527934)
-FCMVaultTest:test_Fees_OffByDefault() (gas: 367648)
-FCMVaultTest:test_Fees_PerformanceAccrualAndHWM() (gas: 564493)
-FCMVaultTest:test_Fees_RecipientNotAllowlistedSkips() (gas: 473089)
-FCMVaultTest:test_Fees_SetAccessAndCaps() (gas: 142006)
-FCMVaultTest:test_Harvest_FrozenDuringPendingRecovery() (gas: 458974)
-FCMVaultTest:test_Harvest_NoopOnDustSurplus() (gas: 4792450)
-FCMVaultTest:test_InitialRoles() (gas: 25353)
-FCMVaultTest:test_Integration_DepositRebalanceRedeem() (gas: 662636)
+FCMVaultTest:test_Deposit_RevertsOnZeroApproval() (gas: 127517)
+FCMVaultTest:test_Deposit_RevertsWhenUnderwaterWithHolders() (gas: 489898)
+FCMVaultTest:test_Deposit_TwoDepositorsProRata() (gas: 526899)
+FCMVaultTest:test_Fees_AccruePermissionlessSettersGated() (gas: 372690)
+FCMVaultTest:test_Fees_AccruesOnRebalance() (gas: 566863)
+FCMVaultTest:test_Fees_AccruesOnRedeemAndDeAllowlistDoesNotBrick() (gas: 835304)
+FCMVaultTest:test_Fees_AccruesOnRedeemInKind() (gas: 667086)
+FCMVaultTest:test_Fees_CombinedAccrual() (gas: 568735)
+FCMVaultTest:test_Fees_GrossUpDeliversTrueRate() (gas: 530816)
+FCMVaultTest:test_Fees_ManagementAccrual() (gas: 530863)
+FCMVaultTest:test_Fees_ManagementClampedAtOneYear() (gas: 530732)
+FCMVaultTest:test_Fees_NoAccrualAfterRecovered() (gas: 636927)
+FCMVaultTest:test_Fees_NoPerfInDrawdown() (gas: 553573)
+FCMVaultTest:test_Fees_NoPerfOnFirstDeposit() (gas: 478906)
+FCMVaultTest:test_Fees_NoRetroactiveChargeOnEnable() (gas: 527956)
+FCMVaultTest:test_Fees_OffByDefault() (gas: 367666)
+FCMVaultTest:test_Fees_PerformanceAccrualAndHWM() (gas: 564515)
+FCMVaultTest:test_Fees_RecipientNotAllowlistedSkips() (gas: 473111)
+FCMVaultTest:test_Fees_SetAccessAndCaps() (gas: 142028)
+FCMVaultTest:test_Fuzz_Redeem_WithDebtDust(uint256) (runs: 10000, μ: 676876, ~: 677344)
+FCMVaultTest:test_Harvest_FrozenDuringPendingRecovery() (gas: 458996)
+FCMVaultTest:test_Harvest_NoopOnDustSurplus() (gas: 4792072)
+FCMVaultTest:test_InitialRoles() (gas: 25375)
+FCMVaultTest:test_Integration_DepositRebalanceRedeem() (gas: 729671)
 FCMVaultTest:test_MaxDepositNonZeroForAllowlisted() (gas: 66431)
-FCMVaultTest:test_MaxDepositZeroForNonAllowlisted() (gas: 16499)
-FCMVaultTest:test_MaxMintZeroForNonAllowlisted() (gas: 10038)
-FCMVaultTest:test_Mint_Reverts() (gas: 12757)
-FCMVaultTest:test_NonAdminCannotGrantRole() (gas: 18792)
-FCMVaultTest:test_PriceLimit_OracleMathMatchesOracleAndSlippage() (gas: 4413665)
-FCMVaultTest:test_PriceLimit_SkipFlagTracksSpot() (gas: 4407265)
-FCMVaultTest:test_Rebalance_ConstructorValidatesBands() (gas: 583433)
-FCMVaultTest:test_Rebalance_DeleverSkipsWhenSpotPastBound() (gas: 506187)
-FCMVaultTest:test_Rebalance_DeleversWhenBelowMin() (gas: 502368)
-FCMVaultTest:test_Rebalance_HarvestDoesNotBlockDelever() (gas: 598578)
-FCMVaultTest:test_Rebalance_HarvestNoopBelowYieldFactorMax() (gas: 436409)
-FCMVaultTest:test_Rebalance_HarvestNoopOnDepeg() (gas: 438540)
-FCMVaultTest:test_Rebalance_HarvestNoopWhenNoSurplus() (gas: 448220)
-FCMVaultTest:test_Rebalance_HarvestPartialCollateralLegRepaysRemainder() (gas: 1092476)
-FCMVaultTest:test_Rebalance_HarvestRepaysPartialDebtWhenLeftoverWithinDebt() (gas: 604365)
-FCMVaultTest:test_Rebalance_HarvestRevertsInsteadOfStrandingSurplusWhenCollateralLegMispriced() (gas: 619880)
-FCMVaultTest:test_Rebalance_HarvestSkipsMispricedCollateralLeg() (gas: 514065)
-FCMVaultTest:test_Rebalance_HarvestThenLeversWhenSurplusLarge() (gas: 595372)
-FCMVaultTest:test_Rebalance_HarvestsSurplusAsCollateral() (gas: 569793)
-FCMVaultTest:test_Rebalance_LeverSkipsWhenSpotPastBound() (gas: 505092)
-FCMVaultTest:test_Rebalance_LeversWhenAboveMax() (gas: 501288)
-FCMVaultTest:test_Rebalance_LiquidationRecoveryDoesNotRevert() (gas: 514702)
-FCMVaultTest:test_Rebalance_NoopInsideBand() (gas: 451367)
-FCMVaultTest:test_Rebalance_NoopWhenOffCenterButInBand() (gas: 454493)
-FCMVaultTest:test_Rebalance_PartialDeleverMakesProgress() (gas: 1067599)
-FCMVaultTest:test_Rebalance_PartialLeverMakesProgress() (gas: 1076260)
-FCMVaultTest:test_Rebalance_RespectsLoosenedSlippage() (gas: 607614)
+FCMVaultTest:test_MaxDepositZeroForNonAllowlisted() (gas: 16521)
+FCMVaultTest:test_MaxMintZeroForNonAllowlisted() (gas: 10060)
+FCMVaultTest:test_Mint_Reverts() (gas: 12779)
+FCMVaultTest:test_NonAdminCannotGrantRole() (gas: 18814)
+FCMVaultTest:test_PriceLimit_OracleMathMatchesOracleAndSlippage() (gas: 4413287)
+FCMVaultTest:test_PriceLimit_SkipFlagTracksSpot() (gas: 4406887)
+FCMVaultTest:test_Rebalance_ConstructorValidatesBands() (gas: 583455)
+FCMVaultTest:test_Rebalance_DeleverSkipsWhenSpotPastBound() (gas: 506185)
+FCMVaultTest:test_Rebalance_DeleversWhenBelowMin() (gas: 502364)
+FCMVaultTest:test_Rebalance_HarvestDoesNotBlockDelever() (gas: 598576)
+FCMVaultTest:test_Rebalance_HarvestNoopBelowYieldFactorMax() (gas: 436431)
+FCMVaultTest:test_Rebalance_HarvestNoopOnDepeg() (gas: 438562)
+FCMVaultTest:test_Rebalance_HarvestNoopWhenNoSurplus() (gas: 448242)
+FCMVaultTest:test_Rebalance_HarvestPartialCollateralLegRepaysRemainder() (gas: 1092498)
+FCMVaultTest:test_Rebalance_HarvestRepaysPartialDebtWhenLeftoverWithinDebt() (gas: 604382)
+FCMVaultTest:test_Rebalance_HarvestRevertsInsteadOfStrandingSurplusWhenCollateralLegMispriced() (gas: 619923)
+FCMVaultTest:test_Rebalance_HarvestSkipsMispricedCollateralLeg() (gas: 514083)
+FCMVaultTest:test_Rebalance_HarvestThenLeversWhenSurplusLarge() (gas: 595389)
+FCMVaultTest:test_Rebalance_HarvestsSurplusAsCollateral() (gas: 569809)
+FCMVaultTest:test_Rebalance_LeverSkipsWhenSpotPastBound() (gas: 505112)
+FCMVaultTest:test_Rebalance_LeversWhenAboveMax() (gas: 501304)
+FCMVaultTest:test_Rebalance_LiquidationRecoveryDoesNotRevert() (gas: 514716)
+FCMVaultTest:test_Rebalance_NoopInsideBand() (gas: 451387)
+FCMVaultTest:test_Rebalance_NoopWhenOffCenterButInBand() (gas: 454513)
+FCMVaultTest:test_Rebalance_PartialDeleverMakesProgress() (gas: 1067595)
+FCMVaultTest:test_Rebalance_PartialLeverMakesProgress() (gas: 1076280)
+FCMVaultTest:test_Rebalance_RespectsLoosenedSlippage() (gas: 607609)
 FCMVaultTest:test_Recovery_AccessControl() (gas: 47513)
-FCMVaultTest:test_Recovery_BlocksDepositsAfterExecute() (gas: 590653)
-FCMVaultTest:test_Recovery_BlocksDepositsWhilePending() (gas: 119785)
-FCMVaultTest:test_Recovery_DeleverStaysLiveWhilePending() (gas: 507568)
-FCMVaultTest:test_Recovery_ExecuteRevertsBeforeDelay() (gas: 41022)
-FCMVaultTest:test_Recovery_ExecuteSweepsPositionToOwner() (gas: 550536)
-FCMVaultTest:test_Recovery_NoLeverUpWhilePending() (gas: 462463)
-FCMVaultTest:test_Recovery_OwnerCanCancel() (gas: 31680)
+FCMVaultTest:test_Recovery_BlocksDepositsAfterExecute() (gas: 590671)
+FCMVaultTest:test_Recovery_BlocksDepositsWhilePending() (gas: 119807)
+FCMVaultTest:test_Recovery_DeleverStaysLiveWhilePending() (gas: 507565)
+FCMVaultTest:test_Recovery_ExecuteRevertsBeforeDelay() (gas: 41044)
+FCMVaultTest:test_Recovery_ExecuteSweepsPositionToOwner() (gas: 550554)
+FCMVaultTest:test_Recovery_NoLeverUpWhilePending() (gas: 462484)
+FCMVaultTest:test_Recovery_OwnerCanCancel() (gas: 31698)
 FCMVaultTest:test_Recovery_RedeemInKindStaysOpenWhilePending() (gas: 547208)
-FCMVaultTest:test_Recovery_RedeemStaysOpenWhilePending() (gas: 498308)
-FCMVaultTest:test_RedeemInKind_FullExit() (gas: 531270)
-FCMVaultTest:test_RedeemInKind_PartialExitDoesNotDiluteRemainingHolder() (gas: 749965)
-FCMVaultTest:test_RedeemInKind_WorksWhenDeAllowlisted() (gas: 538400)
-FCMVaultTest:test_Redeem_BurnsSharesAndTransfersToReceiver() (gas: 481336)
-FCMVaultTest:test_Redeem_CaseB_DeepImpairmentFlashCoversAnyHF() (gas: 562758)
-FCMVaultTest:test_Redeem_CaseB_FillsShortfallFromCollateral() (gas: 564720)
-FCMVaultTest:test_Redeem_PartialRedeemUnwindsProportionalSlice() (gas: 482762)
-FCMVaultTest:test_Redeem_RevertsIfNotOwnerAndNoAllowance() (gas: 361463)
-FCMVaultTest:test_Redeem_RoundTripReturnsApproximatelyDeposited() (gas: 477661)
-FCMVaultTest:test_Redeem_SpendsAllowanceWhenOperatorRedeems() (gas: 500964)
-FCMVaultTest:test_Redeem_SurplusPyusdReconciledToWeth() (gas: 489112)
-FCMVaultTest:test_Redeem_TwoDepositorsIndependentRedeem() (gas: 683210)
-FCMVaultTest:test_Redeem_ZeroSharesIsNoop() (gas: 366177)
-FCMVaultTest:test_SetMaxSlippageBps() (gas: 30878)
-FCMVaultTest:test_TransferBetweenAllowlistedHoldersSucceeds() (gas: 401902)
-FCMVaultTest:test_TransferRevertsForDeAllowlistedSender() (gas: 384956)
-FCMVaultTest:test_TransferRevertsForNonAllowlistedRecipient() (gas: 357052)
-FCMVaultTest:test_VaultState_DepositEmitsSnapshot() (gas: 389916)
-FCMVaultTest:test_VaultState_PricesReflectOracles() (gas: 372000)
-FCMVaultTest:test_VaultState_RebalanceLeverEmitsUpdatedSnapshot() (gas: 509472)
-FCMVaultTest:test_VaultState_RebalanceNoopStillEmitsSnapshot() (gas: 453872)
-FCMVaultTest:test_VaultState_RedeemEmitsSnapshot() (gas: 510764)
-FCMVaultTest:test_VaultState_RedeemInKindEmitsSnapshot() (gas: 564659)
-FeesLibTest:testFuzz_FeesToMint_UnreachableNeverHit(uint256,uint256,uint16,uint16,uint256,uint256) (runs: 10000, μ: 11816, ~: 11833)
+FCMVaultTest:test_Recovery_RedeemStaysOpenWhilePending() (gas: 565345)
+FCMVaultTest:test_RedeemInKind_FullExit() (gas: 531288)
+FCMVaultTest:test_RedeemInKind_PartialExitDoesNotDiluteRemainingHolder() (gas: 749983)
+FCMVaultTest:test_RedeemInKind_WorksWhenDeAllowlisted() (gas: 538418)
+FCMVaultTest:test_Redeem_BurnsSharesAndTransfersToReceiver() (gas: 548372)
+FCMVaultTest:test_Redeem_CaseB_DeepImpairmentFlashCoversAnyHF() (gas: 561112)
+FCMVaultTest:test_Redeem_CaseB_FillsShortfallFromCollateral() (gas: 563075)
+FCMVaultTest:test_Redeem_PartialRedeemUnwindsProportionalSlice() (gas: 549799)
+FCMVaultTest:test_Redeem_RevertsIfNotOwnerAndNoAllowance() (gas: 355896)
+FCMVaultTest:test_Redeem_RoundTripReturnsApproximatelyDeposited() (gas: 544705)
+FCMVaultTest:test_Redeem_SpendsAllowanceWhenOperatorRedeems() (gas: 567983)
+FCMVaultTest:test_Redeem_SurplusPyusdReconciledToWeth() (gas: 489227)
+FCMVaultTest:test_Redeem_TwoDepositorsIndependentRedeem() (gas: 750247)
+FCMVaultTest:test_Redeem_ZeroSharesIsNoop() (gas: 366195)
+FCMVaultTest:test_SetMaxSlippageBps() (gas: 30900)
+FCMVaultTest:test_TransferBetweenAllowlistedHoldersSucceeds() (gas: 401920)
+FCMVaultTest:test_TransferRevertsForDeAllowlistedSender() (gas: 384974)
+FCMVaultTest:test_TransferRevertsForNonAllowlistedRecipient() (gas: 357069)
+FCMVaultTest:test_VaultState_DepositEmitsSnapshot() (gas: 389938)
+FCMVaultTest:test_VaultState_PricesReflectOracles() (gas: 372017)
+FCMVaultTest:test_VaultState_RebalanceLeverEmitsUpdatedSnapshot() (gas: 509490)
+FCMVaultTest:test_VaultState_RebalanceNoopStillEmitsSnapshot() (gas: 453894)
+FCMVaultTest:test_VaultState_RedeemEmitsSnapshot() (gas: 584297)
+FCMVaultTest:test_VaultState_RedeemInKindEmitsSnapshot() (gas: 564681)
+FeesLibTest:testFuzz_FeesToMint_UnreachableNeverHit(uint256,uint256,uint16,uint16,uint256,uint256) (runs: 10000, μ: 11805, ~: 11818)
 FeesLibTest:test_FeesToMintBiggerNav_ManagementFeeOnly() (gas: 7730)
 FeesLibTest:test_FeesToMintBiggerNav_PerformanceFeeOnly() (gas: 4318)
 FeesLibTest:test_FeesToMintBiggerNav_PerformanceFeeOnly_730days() (gas: 3795)
@@ -111,7 +112,7 @@ FeesLibTest:test_FeesToMint_USDC() (gas: 9657)
 FeesLibTest:test_FeesToMint_ZeroBeforeElapsed() (gas: 4387)
 FeesLibTest:test_FeesToMint_ZeroWhenMgmtAndPerfAreZero() (gas: 7143)
 FeesLibTest:test_FeesToMint_ZeroWhenNavIsZero() (gas: 7645)
-TvlLimitTest:testFuzz_Deposit_RespectsLimit(uint96,uint96) (runs: 10000, μ: 240931, ~: 358047)
+TvlLimitTest:testFuzz_Deposit_RespectsLimit(uint96,uint96) (runs: 10000, μ: 241532, ~: 358047)
 TvlLimitTest:test_Deposit_BelowLimitSucceeds() (gas: 357712)
 TvlLimitTest:test_Deposit_ExactlyAtLimitSucceeds() (gas: 357573)
 TvlLimitTest:test_Deposit_LimitIsGlobalAcrossUsers() (gas: 523263)
@@ -133,9 +134,9 @@ TvlLimitTest:test_SetMaxTvl_OwnerCanRaiseAndLower() (gas: 36640)
 TvlLimitTest:test_TransferOwnership_EmitsEvent() (gas: 35594)
 TvlLimitTest:test_TransferOwnership_OnlyOwner() (gas: 15750)
 TvlLimitTest:test_TransferOwnership_TransfersControl() (gas: 60677)
-YieldTokenOracleForkTest:test_fork_priceIsSane() (gas: 318139)
-YieldTokenOracleForkTest:test_fork_priceMatchesVaultNav() (gas: 337927)
-YieldTokenOracleTest:test_constructorRejectsAssetMismatch() (gas: 44558)
-YieldTokenOracleTest:test_priceAtParity() (gas: 492041)
-YieldTokenOracleTest:test_priceTracksExchangeRate() (gas: 955299)
-YieldTokenOracleTest:test_priceWithEqualDecimals() (gas: 625578)
+YieldTokenOracleTest:test_constructorRejectsAssetMismatch() (gas: 43822)
+YieldTokenOracleTest:test_constructorRejectsZeroConversionSample() (gas: 38341)
+YieldTokenOracleTest:test_conversionSampleBoundsPricingError() (gas: 912531)
+YieldTokenOracleTest:test_priceAtParity() (gas: 512778)
+YieldTokenOracleTest:test_priceTracksExchangeRate() (gas: 974803)
+YieldTokenOracleTest:test_priceWithEqualDecimals() (gas: 690993)

solidity/src/YieldTokenOracle.sol

@@ -28,6 +28,7 @@ contract YieldTokenOracle is IOracle {
     error ZeroAddress();
     error ZeroConversionSample();
 
+    /// @notice Constructs a new YieldTokenOracle.
     /// @param vault The ERC4626 vault whose shares are being priced.
     /// @param asset The vault's underlying asset; must match `vault.asset()`.
     /// @param conversionSample The sample amount of vault shares used to convert to the underlying asset. Should be

solidity/test/FCMVault.t.sol

@@ -3,7 +3,7 @@ pragma solidity ^0.8.20;
 
 import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 import {Math} from "@openzeppelin/contracts/utils/math/Math.sol";
-import {Test, console} from "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {Vm} from "forge-std/Vm.sol";
 
 import {FCMVault} from "../src/FCMVault.sol";