revert changes that arent needed

Author: janezpodhostnik

client/convert/protobuf.go

@@ -444,7 +444,7 @@ func TransactionToMessage(t flow.Transaction) (*entities.Transaction, error) {
 
 func MessageToTransaction(m *entities.Transaction) (flow.Transaction, error) {
 	if m == nil {
-		return *flow.NewTransaction(), ErrEmptyMessage
+		return flow.Transaction{}, ErrEmptyMessage
 	}
 
 	t := flow.NewTransaction()

transaction.go

@@ -420,19 +420,19 @@ func DecodeTransaction(transactionMessage []byte) (*Transaction, error) {
 	for i, auth := range temp.Payload.Authorizers {
 		authorizers[i] = BytesToAddress(auth)
 	}
-	t := NewTransaction()
-	t.Script = temp.Payload.Script
-	t.Arguments = temp.Payload.Arguments
-	t.ReferenceBlockID = BytesToID(temp.Payload.ReferenceBlockID)
-	t.GasLimit = temp.Payload.GasLimit
-	t.ProposalKey = ProposalKey{
-		Address:        BytesToAddress(temp.Payload.ProposalKeyAddress),
-		KeyIndex:       int(temp.Payload.ProposalKeyIndex),
-		SequenceNumber: temp.Payload.ProposalKeySequenceNumber,
-	}
-	t.Payer = BytesToAddress(temp.Payload.Payer)
-	t.Authorizers = authorizers
-
+	t := &Transaction{
+		Script:           temp.Payload.Script,
+		Arguments:        temp.Payload.Arguments,
+		ReferenceBlockID: BytesToID(temp.Payload.ReferenceBlockID),
+		GasLimit:         temp.Payload.GasLimit,
+		ProposalKey: ProposalKey{
+			Address:        BytesToAddress(temp.Payload.ProposalKeyAddress),
+			KeyIndex:       int(temp.Payload.ProposalKeyIndex),
+			SequenceNumber: temp.Payload.ProposalKeySequenceNumber,
+		},
+		Payer:       BytesToAddress(temp.Payload.Payer),
+		Authorizers: authorizers,
+	}
 	signers := t.signerList()
 	if len(temp.PayloadSignatures) > 0 {
 		payloadSignatures := make([]TransactionSignature, len(temp.PayloadSignatures))

transaction_test.go

@@ -561,16 +561,15 @@ func baseTx() *flow.Transaction {
 }
 
 func copyTxPayload(tx *flow.Transaction) *flow.Transaction {
-	t := flow.NewTransaction()
-	t.Script = tx.Script
-	t.Arguments = tx.Arguments
-	t.ReferenceBlockID = tx.ReferenceBlockID
-	t.GasLimit = tx.GasLimit
-	t.ProposalKey = tx.ProposalKey
-	t.Payer = tx.Payer
-	t.Authorizers = tx.Authorizers
-
-	return t
+	return &flow.Transaction{
+		Script:           tx.Script,
+		Arguments:        tx.Arguments,
+		ReferenceBlockID: tx.ReferenceBlockID,
+		GasLimit:         tx.GasLimit,
+		ProposalKey:      tx.ProposalKey,
+		Payer:            tx.Payer,
+		Authorizers:      tx.Authorizers,
+	}
 }
 
 func copyTxEnvelope(tx *flow.Transaction) *flow.Transaction {