Fix passing numbers as values deprecation notice (#188)

* Fix numbers as values deprecation for tests

* Add changeset

Author: adbario

.changeset/sweet-penguins-cry.md

@@ -0,0 +1,5 @@
+---
+"@onflow/flow-js-testing": patch
+---
+
+Fix numbers as values deprecation warnings for tests

dev-test/deploy.test.js

@@ -84,7 +84,7 @@ describe("interactions - sendTransaction", () => {
 
   test("deploy custom contract with arguments", async () => {
     const message = "Hello, Cadence"
-    const number = 42
+    const number = "42"
     await shallPass(
       deployContract({
         code: `
@@ -128,7 +128,7 @@ describe("interactions - sendTransaction", () => {
       `,
       })
     )
-    expect(numberResult).toBe(String(number))
+    expect(numberResult).toBe(number)
     expect(numberErr).toBe(null)
   })
 })

dev-test/interaction.test.js

@@ -219,7 +219,7 @@ describe("interactions - sendTransaction", () => {
           }
         }
       `
-      const args = [42]
+      const args = ["42"]
       return sendTransaction({code, args})
     })
   })
@@ -233,7 +233,7 @@ describe("interactions - sendTransaction", () => {
           }
         }
       `
-      const args = [42, 1337, "Hello, Cadence"]
+      const args = ["42", "1337", "Hello, Cadence"]
       return sendTransaction({code, args})
     })
   })
@@ -247,7 +247,7 @@ describe("interactions - sendTransaction", () => {
           }
         }
       `
-      const args = [42, 1337, "Hello, Cadence"]
+      const args = ["42", "1337", "Hello, Cadence"]
       return sendTransaction({code, args})
     })
   })

dev-test/metadata.test.js

@@ -32,10 +32,10 @@ describe("metadata examples", () => {
         return metadata["answer"]!
       }
     `
-    const answer = 42
+    const answer = "42"
     const args = [{answer}]
     const [result] = await shallResolve(executeScript({code, args}))
-    expect(result).toBe(String(answer))
+    expect(result).toBe(answer)
   })
 
   test("simple array - [String]", async () => {
@@ -60,12 +60,12 @@ describe("metadata examples", () => {
         return list[0][index] 
       }
     `
-    const value = [1, 3, 3, 7]
-    const index = 3
+    const value = ["1", "3", "3", "7"]
+    const index = "3"
     const args = [[value], index]
 
     const [result, err] = await executeScript({code, args})
-    expect(result).toBe(String(value[index]))
+    expect(result).toBe(value[index])
     expect(err).toBe(null)
   })
 })

dev-test/usage.test.js

@@ -112,7 +112,7 @@ describe("jest methods", () => {
         `,
       })
     )
-    expect(result).toBe(String(42))
+    expect(result).toBe("42")
     expect(err).toBe(null)
   })
 

dev-test/utilities.test.js

@@ -49,11 +49,11 @@ describe("block height offset", () => {
     const [zeroOffset] = await executeScript("get-block-offset")
     expect(zeroOffset).toBe("0")
 
-    const offset = 42
+    const offset = "42"
     await shallPass(sendTransaction("set-block-offset", [manager], [offset]))
 
     const [newOffset] = await executeScript("get-block-offset")
-    expect(newOffset).toBe(String(offset))
+    expect(newOffset).toBe(offset)
   })
 
   it("should read offset with utility method", async () => {
@@ -65,11 +65,11 @@ describe("block height offset", () => {
     const [oldOffset] = await getBlockOffset()
     expect(oldOffset).toBe("0")
 
-    const offset = 42
+    const offset = "42"
     await shallPass(setBlockOffset(offset))
 
     const [newOffset] = await getBlockOffset()
-    expect(newOffset).toBe(String(offset))
+    expect(newOffset).toBe(offset)
   })
 
   it("should update offset in contract", async () => {
@@ -87,7 +87,7 @@ describe("block height offset", () => {
       })
     )
 
-    const offset = 42
+    const offset = "42"
     await shallPass(manager.setBlockOffset(offset))
 
     const realBlock = await query({
@@ -110,7 +110,7 @@ describe("block height offset", () => {
     )
 
     // Expect 1 higher than initial block height + offset due to sealed TX @ manager.setBlockOffset
-    expect(Number(currentBlock)).toBe(Number(realBlock) + offset)
+    expect(Number(currentBlock)).toBe(Number(realBlock) + Number(offset))
   })
 })
 
@@ -136,11 +136,11 @@ describe("block height offset utilities", () => {
     const [offset] = await shallResolve(manager.getBlockOffset())
     expect(offset).toBe("0")
 
-    const blockOffset = 42
+    const blockOffset = "42"
     await shallPass(manager.setBlockOffset(blockOffset))
 
     const [newOffset] = await shallResolve(manager.getBlockOffset())
-    expect(newOffset).toBe(String(blockOffset))
+    expect(newOffset).toBe(blockOffset)
   })
 })
 
@@ -167,12 +167,12 @@ describe("timestamp offset", () => {
     const [zeroOffset] = await executeScript("get-timestamp-offset")
     expect(zeroOffset).toBe("0.00000000")
 
-    const offset = 42
+    const offset = "42"
     await shallPass(
       sendTransaction("set-timestamp-offset", [manager], [offset])
     )
     const [newOffset] = await executeScript("get-timestamp-offset")
-    expect(newOffset).toBe(offset.toFixed(8))
+    expect(newOffset).toBe(Number(offset).toFixed(8))
   })
 
   it("should read offset with utility method", async () => {
@@ -184,11 +184,11 @@ describe("timestamp offset", () => {
     const [oldOffset] = await getTimestampOffset()
     expect(oldOffset).toBe("0.00000000")
 
-    const offset = 42
+    const offset = "42"
     await shallPass(setTimestampOffset(offset))
 
     const [newOffset] = await getTimestampOffset()
-    expect(newOffset).toBe(offset.toFixed(8))
+    expect(newOffset).toBe(Number(offset).toFixed(8))
   })
 
   it("should update offset in contract", async () => {
@@ -206,7 +206,7 @@ describe("timestamp offset", () => {
       })
     )
 
-    const offset = 42
+    const offset = "42"
     await shallPass(manager.setTimestampOffset(offset))
 
     const realTimestamp = await query({
@@ -228,7 +228,9 @@ describe("timestamp offset", () => {
       })
     )
 
-    expect(Number(currentTimestamp)).toBe(Number(realTimestamp) + offset)
+    expect(Number(currentTimestamp)).toBe(
+      Number(realTimestamp) + Number(offset)
+    )
   })
 })
 
@@ -254,11 +256,11 @@ describe("timestamp offset utilities", () => {
     const [offset] = await shallResolve(manager.getTimestampOffset())
     expect(offset).toBe("0.00000000")
 
-    const blockOffset = 42
+    const blockOffset = "42"
     await shallPass(manager.setTimestampOffset(blockOffset))
 
     const [newOffset] = await shallResolve(manager.getTimestampOffset())
-    expect(newOffset).toBe(blockOffset.toFixed(8))
+    expect(newOffset).toBe(Number(blockOffset).toFixed(8))
   })
 })
 
@@ -281,11 +283,11 @@ describe("dev tests", () => {
   })
 
   it("should return proper offset, when changed", async () => {
-    const offset = 42
+    const offset = "42"
     const manager = await getServiceAddress()
     await shallPass(sendTransaction("set-block-offset", [manager], [offset]))
     const [newOffset] = await executeScript("get-block-offset")
-    expect(newOffset).toBe(String(offset))
+    expect(newOffset).toBe(offset)
   })
 })
 

examples/03-deploy-contract.test.js

@@ -29,7 +29,7 @@ test("deploy contract", async () => {
             }
         }
     `
-  const args = [1337]
+  const args = ["1337"]
 
   await shallPass(deployContract({to, name, code, args}))
 

examples/07-block-offset.test.js

@@ -32,7 +32,7 @@ test("block offset", async () => {
   expect(normalResult).toBe("1")
 
   // Offset current block height by 42
-  await setBlockOffset(42)
+  await setBlockOffset("42")
   // Let's check that offset value on Manager is actually changed to 42
   const [blockOffset] = await getBlockOffset()
   expect(blockOffset).toBe("42")

examples/08-execute-script.test.js

@@ -26,16 +26,16 @@ test("execute script", async () => {
 
   // args is just an array of values in the same order as they are defined in script code
   const args = [
-    1337,
+    "1337",
     true,
     "Hello, Cadence",
     "1.337",
-    [1, 3, 3, 7],
+    ["1", "3", "3", "7"],
     {
       name: "Cadence",
       status: "active",
     },
-    42,
+    "42",
   ]
   const name = "log-args"
 

examples/101-pass-int-dictionary.test.js

@@ -15,7 +15,7 @@ test("pass int dictionary", async () => {
     }
   `
 
-  const args = [{0: 1, 1: 42}, 1]
+  const args = [{0: "1", 1: "42"}, "1"]
 
   const [result] = await shallResolve(executeScript({code, args}))
   expect(result).toBe("42")