Skip to content

Commit f94463c

Browse files
author
Guy Pavlov
authored
Merge pull request #279 from onflow/amit/bug-fixes
Amit/bug fixes
2 parents 559779f + 6a6632a commit f94463c

File tree

3 files changed

+5
-22
lines changed

3 files changed

+5
-22
lines changed

src/components/CadenceEditor/index.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ const CadenceEditor = (props: any) => {
144144
if (editor) {
145145
setupEditor();
146146
}
147-
}, [editor, project.active.index, project.active.type]);
147+
}, [editor, project.active.index, project.active.type, project.project.accounts]);
148148

149149
// "initEditor" will create new instance of Monaco Editor and set it up
150150
const initEditor = async () => {

src/hooks/useLanguageServer.ts

+2-16
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import { useEffect, useState, useMemo } from 'react';
1+
import { useEffect, useState } from 'react';
22
import { CadenceLanguageServer, Callbacks } from 'util/language-server';
33
import { MonacoServices } from 'monaco-languageclient/lib/monaco-services';
44
import * as monaco from 'monaco-editor/esm/vs/editor/editor.api';
55
import { createCadenceLanguageClient } from 'util/language-client';
66
import { useProject } from 'providers/Project/projectHooks';
7-
import debounce from "util/debounce";
87

98
let monacoServicesInstalled = false;
109

@@ -88,21 +87,12 @@ export default function useLanguageServer() {
8887
});
8988
};
9089

91-
const debouncedServerRestart = useMemo(
92-
() => debounce(restartServer, 150),
93-
[languageServer]
94-
)
95-
9690
useEffect(() => {
9791
if (languageServer) {
9892
languageServer.updateCodeGetter(getCode);
9993
}
10094
}, [project.project.accounts]);
10195

102-
// TODO: Disable this, once the cadence language server package is updated
103-
useEffect(debouncedServerRestart, [project.project.accounts, project.active]);
104-
105-
10696
useEffect(() => {
10797
// The Monaco Language Client services have to be installed globally, once.
10898
// An editor must be passed, which is only used for commands.
@@ -117,19 +107,15 @@ export default function useLanguageServer() {
117107
restartServer();
118108
}, []);
119109

120-
121-
122110
useEffect(() => {
123111
if (!languageClient) {
124112
launchLanguageClient(callbacks, languageServer, setLanguageClient).then();
125113
}
126114
}, [languageServer]);
127115

128-
129-
130116
return {
131117
languageClient,
132118
languageServer,
133119
restartServer,
134120
};
135-
}
121+
}

src/providers/Project/index.tsx

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, {createContext, useState, useMemo} from 'react';
1+
import React, {createContext, useState} from 'react';
22
import { useApolloClient, useQuery } from '@apollo/react-hooks';
33
import { navigate, useLocation, Redirect } from '@reach/router';
44
import ProjectMutator from './projectMutator';
@@ -349,10 +349,7 @@ export const ProjectProvider: React.FC<ProjectProviderProps> = ({
349349
}
350350
};
351351

352-
const activeEditor = useMemo(
353-
getActiveEditor,
354-
[active.type, active.index, project]
355-
)
352+
const activeEditor = getActiveEditor()
356353

357354
const location = useLocation();
358355
if (isLoading) return null;

0 commit comments

Comments
 (0)