SyntaxError: Unexpected token N in JSON at position 0

[greatestview]

My homebridge log is filled with these errors:

[06/02/2022, 21:56:04] [MyVacuum] Error parsing current status info: SyntaxError: Unexpected token N in JSON at position 0
[06/02/2022, 21:56:13] [MyVacuum] Error parsing firmware info: SyntaxError: Unexpected token N in JSON at position 0

The first line appears every 10 seconds, the second infrequently.

First I tought it might be the same issue as described in #16 (and closed #12, #13, #14, #18), but that happens with Valetudo RE while my vacuum runs Valetudo (without RE).

Any ideas? @onfoot, which version combination is working for you?

Versions:

• homebridge-valetudo-xiaomi-vacuum: 0.2.0
• Valetudo 2022.02.01 (same issue on 2022.01)
• Node: 16.13.1
• NPM: 8.1.2

[onfoot]

The plugin works with both versions, but the appropriate one must be indicated in the config. I guess I need to add an option for more verbose logging so it shows the whole string along with the request URL, so I can pinpoint it more easily. Currently I'm running RE, but want to start testing both, so the plugin is more reliable across the board.

[robinfdx]

Hi @onfoot & @greatestview

I've the same issue with my Gen1 and Valetudo RE v0.10.7 (latest).

[2/10/2022, 11:33:47 AM] [Aspiro2000] Error parsing current status info: SyntaxError: Unexpected token N in JSON at position 0
[2/10/2022, 11:33:49 AM] [Aspiro2000] Error parsing firmware info: SyntaxError: Unexpected token N in JSON at position 0

When i check the JSON return of /api/current_status :

{
"msg_ver":8,
"state":8,
"battery":100,
"clean_time":2987,
"clean_area":45385000,
"error_code":0,
"map_present":1,
"in_cleaning":0,
"fan_power":100,
"dnd_enabled":0,
"human_state":"Charging",
"human_error":"No error",
"model":"rockrobo.vacuum.v1"
}

When i check the JSON return of /api/get_fw_version :

{
"version":"miio-client 3.3.9\n",
"build":"004028",
"nodejs":"v12.22.1",
"valetudo":"v0.10.7"
}

Any ideas @onfoot ?

Thank for your help 🙏

[onfoot]

@robinfdx Have you set the legacy-mode flag to true for your RE vacuum?

[robinfdx]

@onfoot : Yes i've, like this :

{
"bridge": {
"name": "Homebridge",
"username": "XX:XX:XX:XX:XX:XX",
"port": 5XXXX,
"pin": "XXX-XXX-XXX"
},

"description": "Configuration Xiaomi",

"accessories": [
{
    "accessory": "ValetudoXiaomiVacuum",
    "name": "Aspiro2000",
    "ip": "192.168.XX.XX",

"legacy-mode": true
}
],

"platforms": [
]

}

I've restart homebridge but same thing

[robinfdx]

@onfoot : do you ve any idea about this problem ? 😊

[onfoot]

If you can, please enable debug mode in your homebridge and let me know, what the raw responses are when the error occurs. This is usually accomplished by uncommenting DEBUG=* option in /etc/default/homebridge, at least on raspbian or probably unbuntu/debian-based distributions.

[greatestview]

@onfoot, I finally figured it out! Thanks to this guy on reddit, I managed to debug your plugin directly on my pi instance:

The error occurs inside sendJSONRequest and the message is No credentials provided. Well, that was obvious. Your plugin does not work with Valetudo and HTTP Basic Auth activated!

This line in vacuumvaletudo.js#L370 with call to sendJSONRequest caused the error:

const response = await sendJSONRequest({ url: VacuumValetudo.statusUrl(this.ip) });

The solution is very simple and only a few lines of code: Just include HTTP Basic Auth into the config and pass it as a parameter to sendJSONRequest, since it can already be handled there:

const response = await sendJSONRequest({
  url: VacuumValetudo.statusUrl(this.ip),
  authentication: config.basicAuth ? config.basicAuth : null,
});

There are multiple calls to sendJSONRequest inside vacuumvaletudo.js and vacuumre.js. I’m not sure about the other calls. I could provide a pull request with this fix for all sendJSONRequest calls, but I could not test the Valetudo RE part and I need to know first, if Valetudo RE supports Basic Auth.

Workaround since then: Disable HTTP Basic Auth in Valetudo.

[onfoot]

That's awesome, thanks for doing the research! I have another plugin I had to put basic auth support into, so the simple http request function I made for all my plugins already supports it, so I'll make sure first if both valetudos work the same way and enable the support here.

[T-Bone90]

Any news? :)

[onfoot]

Coming right up! Hopefully I'll test the change today and push out an update. Will be untested on Valetudo non-RE for now, though.

[onfoot]

v0.3.0 is ready for consumption. 🎉

[T-Bone90]

Thanks for the new version and happy new year :)
I found a Bug in the new version..

No plugin was found for the accessory "Valetudo Vacuum" in your config.json. Please make sure the corresponding plugin is installed correctly.

In the Config I have two entrys for your plugin. The second entry come with v0.3.0.

"accessory": "ValetudoXiaomiVacuum", "name": "Roborock S5", "ip": "xxxxxx"

"name": "Robi", "ip": "xxxxxx", "legacy-mode": false, "accessory": "Valetudo Vacuum"

If I delete the first entry, the Error looks the same. I think I must remove the first entry. Or the plugins write the wrong "accessory" entry in the config.

If I change name or ip in your plugin config, the second entry is change.

I think the new version use the wrong "accessory" name.
"Valetudo Vacuum" instead of "ValetudoXiaomiVacuum"
:)

[onfoot]

That's interesting, since your error message says the opposite. 😄 You seem to have one "Valetudo Vacuum" plugin configured instead of "ValetudoXiaomiVacuum".

[T-Bone90]

OK that's weird. I just installed your plugin. I used another Roborock Plugin in the past but at the moment your plugin is the only.

The error message says I must delete the second entry (Valetudo Vacuum) because there is no Plugin "Valetudo Vacuum".
But If I change the settings in "your" plugin, the second entry in my config file is change. So I can't delete the second plugin. Your plugin use the second entry (Valetudo Vacuum).
So I think it's a bug, Something is wrong. :)

[greatestview]

Same here, was ValetudoXiaomiVacuum before, after update a new accessory Valetudo Vacuum was created. After cleaning up the config and removing Valetudo Vacuum it's working again.