Fix combining 2 runs separated by a break, 2nd line should not be prefixed by a space

Author: onizet

src/Html2OpenXml/Expressions/PhrasingElementExpression.cs

@@ -218,6 +218,10 @@ protected static IEnumerable<OpenXmlElement> CombineRuns(IEnumerable<OpenXmlElem
                 }
                 endsWithSpace = text[text.Length - 1].IsSpaceCharacter();
             }
+            else if (run.LastChild is Break)
+            {
+                endsWithSpace = true;
+            }
             yield return run;
         }
     }

test/HtmlToOpenXml.Tests/ElementTests.cs

@@ -136,7 +136,7 @@ public void TextWithBreak_ReturnsRunWithBreak()
         {
             var elements = converter.Parse(@"Lorem<br/>Ipsum");
             Assert.That(elements, Has.Count.EqualTo(1));
-            Assert.That(elements[0].ChildElements, Has.Count.EqualTo(4));
+            Assert.That(elements[0].ChildElements, Has.Count.EqualTo(3));
 
             Assert.Multiple(() =>
             {

test/HtmlToOpenXml.Tests/WhitespaceTests.cs

@@ -74,12 +74,28 @@ public void AnchorWithImgThenText_ReturnsCollapsedStartingWhitespace()
         }
 
         [Test(Description = "`nbsp` entities should not be collapsed")]
-        public void NonBreakingSpaceEntities_ReturnsPreserveedWhitespace()
+        public void NonBreakingSpaceEntities_ReturnsPreservedWhitespace()
         {
             var elements = converter.Parse("<h1>&nbsp;&nbsp; Hello      World!     </h1>");
             Assert.That(elements, Has.Count.EqualTo(1));
             Assert.That(elements, Has.All.TypeOf<Paragraph>());
             Assert.That(elements[0].InnerText, Is.EqualTo("   Hello World!"));
         }
+
+        [Test(Description = "Consecutive runs separated by a break should not prefix the 2nd line with a space")]
+        public void ConsecutivePhrasingWithBreak_ReturnsSecondLineWithNoSpaces()
+        {
+            var elements = converter.Parse("<span>Hello<br><span>World</span></span>");
+            Assert.That(elements, Has.Count.EqualTo(1));
+            Assert.That(elements, Has.All.TypeOf<Paragraph>());
+            Assert.That(elements[0].InnerText, Is.EqualTo("HelloWorld"));
+            var runs = elements[0].Elements<Run>();
+            Assert.That(runs.Count(), Is.EqualTo(3));
+            Assert.Multiple(() => {
+                Assert.That(runs.ElementAt(1).LastChild, Is.TypeOf<Break>());
+                Assert.That(runs.ElementAt(2).FirstChild, Is.TypeOf<Text>());
+            });
+            Assert.That(((Text)runs.ElementAt(2).FirstChild).Text, Is.EqualTo("World"));
+        }
     }
 }