Layer copy pasting #1791
Closed
Layer copy pasting #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the llm prompt
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to f54c471 in 3 minutes and 1 seconds
More details
- Looked at
504lines of code in11files - Skipped
0files when reviewing. - Skipped posting
14drafted comments based on config settings.
1. apps/studio/.env.example:8
- Draft comment:
Added Firecrawl API key placeholder. Ensure that valid keys are provided and sensitive data is not exposed in production. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. apps/studio/package.json:43
- Draft comment:
Added '@mendable/firecrawl-js' dependency for Firecrawl integration. Confirm compatibility with other dependencies. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. apps/studio/src/lib/editor/engine/code/index.ts:67
- Draft comment:
Improved error handling in getCodeBlock using try/catch solidly prevents crashes when retrieving code blocks fails. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. apps/studio/src/lib/editor/engine/copy/index.ts:163
- Draft comment:
Typo in duplicate(): should check 'this.copied' instead of 'this.copy' to verify that the copied element exists. - Reason this comment was not posted:
Marked as duplicate.
5. apps/studio/src/lib/editor/engine/element/index.ts:139
- Draft comment:
Enhanced error handling in element deletion using try/catch with toast notifications improves user feedback. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
6. apps/studio/src/lib/projects/create.ts:92
- Draft comment:
sendPrompt() now includes a 'crawledContent' parameter. Verify that the backend channel properly handles this new parameter. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
7. apps/studio/src/lib/services/crawler.ts:25
- Draft comment:
New CrawlerService encapsulates Firecrawl integration effectively. Ensure proper API key loading and error messaging. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
8. apps/studio/src/locales/en/translation.json:71
- Draft comment:
New 'crawl' translation keys added for the crawl feature. Confirm consistency with the UI and other language files. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
9. apps/studio/src/routes/editor/LayersPanel/Tree/PageTreeNode.tsx:79
- Draft comment:
Page duplication logic now uses regex to update the page name. Ensure this handles edge cases (e.g., single-segment paths) as expected. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
10. apps/studio/src/routes/projects/PromptCreation/PromptingCard.tsx:199
- Draft comment:
Typo in toast title: 'URl crawled' should be 'URL crawled'. - Reason this comment was not posted:
Marked as duplicate.
11. apps/web/client/messages/en.json:67
- Draft comment:
Updated translations include new crawl feature keys; ensure placeholder formatting and keys match those in the studio translations. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
12. apps/studio/src/lib/editor/engine/copy/index.ts:163
- Draft comment:
Typographical/lexical issue: The condition 'if (!this.copy)' seems incorrect because 'copy' is a function and not the copied content. It likely should be checking 'if (!this.copied)' to verify if any content was copied. - Reason this comment was not posted:
Marked as duplicate.
13. apps/studio/src/routes/projects/PromptCreation/PromptingCard.tsx:200
- Draft comment:
Typo: The toast title 'URl crawled' should have 'URL' in all uppercase. Please change it to 'URL crawled'. - Reason this comment was not posted:
Marked as duplicate.
14. apps/web/client/messages/en.json:71
- Draft comment:
Typo detected: In the placeholder text, 'https:://' should be corrected to 'https://'. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_LsmjCL2l1nmoCebh
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| this.copied = savedCopied; | ||
| try { | ||
| await this.copy(); | ||
| if (!this.copy) { |
There was a problem hiding this comment.
Bug: In duplicate(), check this.copied instead of this.copy (a method reference), else the check will always be truthy.
Suggested change
| if (!this.copy) { | |
| if (!this.copied) { |
apps/studio/src/routes/projects/PromptCreation/PromptingCard.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Fixed the typo Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Fixed typo Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
Hey, thanks for checking. |
|
Thanks for your feedback. The issue is much complex than what i thought would be. I am looking for the actual reason for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes Copy-pasting a layer unexpectedly duplicates it
Related Issues
fixes #1723
Testing
Tested locally
Screenshots
Screencast.from.2025-04-16.22-34-00.webm
Important
Fixes layer duplication bug, adds website crawling feature, and improves error handling and UI in Onlook Studio.
CopyManagerby ensuring the copied state is restored after duplication.CrawlerServiceincrawler.ts.PromptingCard.tsxto handle URL input for crawling and display results.CodeManagerandElementManagerby adding try-catch blocks and error messages.CopyManagerandPageTreeNode.tsx.translation.jsonandmessages/en.jsonto include new strings for crawling feature.PageTreeNode.tsxto handle page duplication with a new naming convention.package.jsonfor@mendable/firecrawl-js.This description was created by
for f54c471. It will automatically update as commits are pushed.