Commit 0cf0f15
committed
fix(opal): stop hidden Hoverable items from swallowing clicks
An `appear-on-hover` item only set `opacity: 0`, so at rest it was invisible
but still hit-testable. In the sidebar that put a transparent popover trigger
above the row's navigation overlay, which is `z-99` to the actions slot's
`z-100`: clicking the right edge of a row opened the menu instead of opening
the chat.
This is why the classes it replaced worked — both `display: none` and
`visibility: hidden` take the element out of hit-testing, and opacity does
not. Every opacity rule now moves `pointer-events` with it.
Local mode is deliberately excluded. It reveals on its own hover, so an item
that could not be hovered could never be revealed.
Also forwards `style` to the send button's spinner. Opal's iconWrapper sizes
icons through `style`, not classes, so dropping it left the loader at its own
default size. LineItem sizes with classes instead, which is why the file
picker's loader does not need this.1 parent 61cf55a commit 0cf0f15
2 files changed
Lines changed: 18 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
22 | 31 | | |
23 | 32 | | |
24 | 33 | | |
25 | 34 | | |
26 | 35 | | |
27 | 36 | | |
28 | 37 | | |
| 38 | + | |
29 | 39 | | |
30 | 40 | | |
31 | 41 | | |
| |||
40 | 50 | | |
41 | 51 | | |
42 | 52 | | |
| 53 | + | |
43 | 54 | | |
44 | 55 | | |
45 | 56 | | |
| |||
49 | 60 | | |
50 | 61 | | |
51 | 62 | | |
| 63 | + | |
52 | 64 | | |
53 | 65 | | |
54 | 66 | | |
55 | 67 | | |
56 | 68 | | |
| 69 | + | |
57 | 70 | | |
58 | 71 | | |
59 | 72 | | |
| |||
71 | 84 | | |
72 | 85 | | |
73 | 86 | | |
| 87 | + | |
74 | 88 | | |
75 | 89 | | |
76 | 90 | | |
| |||
85 | 99 | | |
86 | 100 | | |
87 | 101 | | |
| 102 | + | |
88 | 103 | | |
89 | 104 | | |
90 | 105 | | |
| |||
93 | 108 | | |
94 | 109 | | |
95 | 110 | | |
| 111 | + | |
96 | 112 | | |
97 | 113 | | |
98 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
371 | 371 | | |
372 | 372 | | |
373 | 373 | | |
374 | | - | |
| 374 | + | |
375 | 375 | | |
376 | 376 | | |
| 377 | + | |
377 | 378 | | |
378 | 379 | | |
379 | 380 | | |
| |||
0 commit comments