quick fix

Author: pablonyx

backend/alembic/versions/a31fc5e4d9c8_add_cascade_delete_to_connector_documents.py

@@ -0,0 +1,35 @@
+"""add_cascade_delete_to_connector_documents
+
+Revision ID: a31fc5e4d9c8
+Revises: 3bd4c84fe72f
+Create Date: 2025-03-29 12:00:00.000000
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "a31fc5e4d9c8"
+down_revision = "3bd4c84fe72f"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    """
+    This migration adds cascade delete to the relationship between Connector and
+    DocumentByConnectorCredentialPair to fix an issue where deleting a Connector
+    would fail because SQLAlchemy was trying to blank out primary key columns in
+    DocumentByConnectorCredentialPair records instead of deleting them.
+
+    The actual change is in the model definition (models.py) where we've added
+    cascade="all, delete-orphan" to the documents_by_connector relationship in
+    the Connector model.
+
+    This is a metadata-only change and doesn't require schema modifications.
+    """
+    # This is a metadata-only change to the SQLAlchemy model, no SQL needed
+
+
+def downgrade() -> None:
+    """
+    No downgrade required as this is a metadata-only change
+    """

backend/onyx/db/models.py

@@ -694,7 +694,11 @@ class Connector(Base):
     )
     documents_by_connector: Mapped[
         list["DocumentByConnectorCredentialPair"]
-    ] = relationship("DocumentByConnectorCredentialPair", back_populates="connector")
+    ] = relationship(
+        "DocumentByConnectorCredentialPair",
+        back_populates="connector",
+        cascade="all, delete-orphan",
+    )
 
     # synchronize this validation logic with RefreshFrequencySchema etc on front end
     # until we have a centralized validation schema