From c222ae12221226bed901a20d7a80ac69a1f3cdc6 Mon Sep 17 00:00:00 2001 From: Subash-Mohan Date: Mon, 7 Apr 2025 09:17:54 +0530 Subject: [PATCH] update test expectations for Highspot connector --- backend/onyx/connectors/highspot/connector.py | 3 +++ .../daily/connectors/highspot/test_highspot_connector.py | 8 +++++--- .../daily/connectors/highspot/test_highspot_data.json | 6 +++--- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/backend/onyx/connectors/highspot/connector.py b/backend/onyx/connectors/highspot/connector.py index 99de7fe061..66b2609b65 100644 --- a/backend/onyx/connectors/highspot/connector.py +++ b/backend/onyx/connectors/highspot/connector.py @@ -350,6 +350,9 @@ def _get_item_content(self, item_details: Dict[str, Any]) -> str: return default_content else: + logger.warning( + f"Item {item_id} has unsupported format: {file_extension}" + ) return default_content except HighspotClientError as e: diff --git a/backend/tests/daily/connectors/highspot/test_highspot_connector.py b/backend/tests/daily/connectors/highspot/test_highspot_connector.py index 1a74847028..98b7bf2c5e 100644 --- a/backend/tests/daily/connectors/highspot/test_highspot_connector.py +++ b/backend/tests/daily/connectors/highspot/test_highspot_connector.py @@ -106,9 +106,11 @@ def test_highspot_connector_slim( assert len(all_slim_doc_ids) > 0 -@pytest.mark.xfail( - reason="failing, needs fix", -) +"""This test might fail because of how Highspot handles changes to the document's +"updated at" property. It is marked as expected to fail until we can confirm the behavior.""" + + +@pytest.mark.xfail(reason="Highspot is not returning updated documents as expected.") @patch( "onyx.file_processing.extract_file_text.get_unstructured_api_key", return_value=None, diff --git a/backend/tests/daily/connectors/highspot/test_highspot_data.json b/backend/tests/daily/connectors/highspot/test_highspot_data.json index 2ebd099198..1753fcf124 100644 --- a/backend/tests/daily/connectors/highspot/test_highspot_data.json +++ b/backend/tests/daily/connectors/highspot/test_highspot_data.json @@ -3,8 +3,8 @@ "semantic_identifier": "Highspot in Action _ Salesforce Integration", "link": "https://www.highspot.com/items/67cd8eb35d3ee0487de2e704", "poll_source": { - "target_doc_id":"67ef9edcc3f40b2bf3d816a8", - "semantic_identifier":"A Brief Introduction To AI", - "link":"https://www.highspot.com/items/67ef9edcc3f40b2bf3d816a8" + "target_doc_id":"67efb452c3f40bcca2b48ca5", + "semantic_identifier":"Introduction to Intelligent Agents", + "link":"https://www.highspot.com/items/67efb452c3f40bcca2b48ca5" } }