fixed: some intrinsic interfaces might need to yield

Author: brendanfh

compiler/include/astnodes.h

@@ -2413,7 +2413,7 @@ AstFunction* macro_resolve_header(Context *context, AstMacro* macro, Arguments*
 Type* polymorphic_struct_lookup(Context *context, AstPolyStructType* ps_type, bh_arr(AstPolySolution) slns, OnyxFilePos pos, b32 error_if_failed);
 Type* polymorphic_union_lookup(Context *context, AstPolyUnionType* pu_type, bh_arr(AstPolySolution) slns, OnyxFilePos pos, b32 error_if_failed);
 
-b32 resolve_intrinsic_interface_constraint(Context *context, AstConstraint *constraint);
+TypeMatch resolve_intrinsic_interface_constraint(Context *context, AstConstraint *constraint);
 
 void track_declaration_for_symbol_info(Context *context, OnyxFilePos, AstNode *);
 void track_documentation_for_symbol_info(Context *context, AstNode *, AstBinding *);

compiler/src/astnodes.c

@@ -1996,18 +1996,16 @@ AstCall * create_implicit_for_expansion_call(Context *context, AstFor *fornode)
 }
 
 
-
-b32 resolve_intrinsic_interface_constraint(Context *context, AstConstraint *constraint) {
-    AstInterface *interface = constraint->interface;
-    Type* type = type_build_from_ast(context, (AstType *) constraint->args[0]);
-    if (!type) return 0;
-
+static b32 resolve_intrinsic_interface_constraint_inner(Context *context, AstInterface *interface, Type *type) {
     if (!strcmp(interface->name, "type_is_bool"))     return type_is_bool(type);
     if (!strcmp(interface->name, "type_is_int"))      return type_is_integer(type);
     if (!strcmp(interface->name, "type_is_float"))    return type->kind == Type_Kind_Basic && (type->Basic.flags & Basic_Flag_Float);
     if (!strcmp(interface->name, "type_is_number"))   return type->kind == Type_Kind_Basic && (type->Basic.flags & Basic_Flag_Numeric);
     if (!strcmp(interface->name, "type_is_simd"))     return type->kind == Type_Kind_Basic && (type->Basic.flags & Basic_Flag_SIMD);
-    if (!strcmp(interface->name, "type_is_pointer"))  return type_is_pointer(type) || type_is_rawptr(type);
+    if (!strcmp(interface->name, "type_is_pointer"))  {
+        printf("RUNNING TYPE IS POINTER ON: %s\n", type_get_name(context, type));
+        return type_is_pointer(type) || type_is_rawptr(type);
+    }
     if (!strcmp(interface->name, "type_is_enum"))     return type->kind == Type_Kind_Enum;
     if (!strcmp(interface->name, "type_is_simple"))   return type->kind == Type_Kind_Basic
                                                           || type->kind == Type_Kind_Enum
@@ -2022,3 +2020,16 @@ b32 resolve_intrinsic_interface_constraint(Context *context, AstConstraint *cons
     if (!strcmp(interface->name, "type_is_function")) return type->kind == Type_Kind_Function;
     return 0;
 }
+
+TypeMatch resolve_intrinsic_interface_constraint(Context *context, AstConstraint *constraint) {
+    AstInterface *interface = constraint->interface;
+    Type* type = type_build_from_ast(context, (AstType *) constraint->args[0]);
+    if (!type) return TYPE_MATCH_YIELD;
+
+    if (resolve_intrinsic_interface_constraint_inner(context, interface, type)) {
+        return TYPE_MATCH_SUCCESS;
+    } else {
+        return TYPE_MATCH_FAILED;
+    }
+}
+

compiler/src/checker.c

@@ -5244,13 +5244,18 @@ CHECK_FUNC(interface_constraint, AstConstraint *constraint) {
 
     // #intrinsic interfaces
     if (constraint->interface->is_intrinsic) {
-        b32 success = resolve_intrinsic_interface_constraint(context, constraint);
-        if (success) {
-            *constraint->report_status = Constraint_Check_Status_Success;
-            return Check_Complete;
-        } else {
-            *constraint->report_status = Constraint_Check_Status_Failed;
-            return Check_Failed;
+        TypeMatch result = resolve_intrinsic_interface_constraint(context, constraint);
+        switch (result) {
+            case TYPE_MATCH_SUCCESS: 
+                *constraint->report_status = Constraint_Check_Status_Success;
+                return Check_Complete;
+
+            case TYPE_MATCH_FAILED: 
+                *constraint->report_status = Constraint_Check_Status_Failed;
+                return Check_Failed;
+
+            default:
+                return Check_Yield;
         }
     }