fixed: polyquery yield issue; polymorph with expression constraint

Author: brendanfh

compiler/src/checker.c

@@ -5609,6 +5609,14 @@ CHECK_FUNC(polyquery, AstPolyQuery *query) {
                 return Check_Yield;
 
             case TYPE_MATCH_YIELD:
+                if (context->cycle_detected) {
+                    ONYX_ERROR(query->token->pos, Error_Critical, "Error solving for polymorphic variable '%b'.", param->poly_sym->token->text, param->poly_sym->token->length);
+                    if (err_msg.text != NULL) onyx_submit_error(context, err_msg);
+                    if (query->error_loc) ONYX_ERROR(query->error_loc->pos, Error_Critical, "Here is where the call is located."); // :ErrorMessage
+                }
+
+                return Check_Yield;
+                
             case TYPE_MATCH_FAILED: {
                 if (solved_something) continue;
 

compiler/src/clone.c

@@ -594,11 +594,15 @@ AstNode* ast_clone(Context *context, void* n) {
             AstConstraint* dc = (AstConstraint *) nn;
             AstConstraint* sc = (AstConstraint *) node;
 
-            dc->args = NULL;
-            bh_arr_new(context->gp_alloc, dc->args, bh_arr_length(sc->args));
-
-            bh_arr_each(AstTyped *, arg, sc->args) {
-                bh_arr_push(dc->args, (AstTyped *) ast_clone(context, (AstNode *) *arg));
+            if (sc->flags & Ast_Flag_Constraint_Is_Expression) {
+                C(AstConstraint, const_expr);
+            } else {
+                dc->args = NULL;
+                bh_arr_new(context->gp_alloc, dc->args, bh_arr_length(sc->args));
+
+                bh_arr_each(AstTyped *, arg, sc->args) {
+                    bh_arr_push(dc->args, (AstTyped *) ast_clone(context, (AstNode *) *arg));
+                }
             }
 
             dc->phase = Constraint_Phase_Waiting_To_Be_Queued;