Skip to content

Commit a162252

Browse files
authored
refactor(versions)!: data_img to data in versions (#49)
Signed-off-by: Kevin Cui <[email protected]>
1 parent 52a7115 commit a162252

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ At the same time, ovm will also create `tmp.img` and data.img in this directory.
7373

7474
#### `-versions` (Required)
7575

76-
Set versions of the kernel/initrd/rootfs/dataImg
76+
Set versions of the kernel/initrd/rootfs/data
7777

78-
Format: `kernel=version,initrd=version,rootfs=version,dataImg=version`
78+
Format: `kernel=version,initrd=version,rootfs=version,data=version`
7979

8080
When the version number differs from the previous one, the new file will be used to overwrite the previous file.
8181

pkg/cli/target.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ import (
1616
)
1717

1818
type versionsJSON struct {
19-
Kernel string `json:"kernel"`
20-
Initrd string `json:"initrd"`
21-
Rootfs string `json:"rootfs"`
22-
DataImg string `json:"data_img"`
19+
Kernel string `json:"kernel"`
20+
Initrd string `json:"initrd"`
21+
Rootfs string `json:"rootfs"`
22+
Data string `json:"data"`
2323

2424
path string
2525
needUpdateJSON bool
@@ -77,8 +77,8 @@ func (v *versionsJSON) get(key string) string {
7777
return v.Initrd
7878
case "rootfs":
7979
return v.Rootfs
80-
case "data_img":
81-
return v.DataImg
80+
case "data":
81+
return v.Data
8282
default:
8383
return ""
8484
}
@@ -93,8 +93,8 @@ func (v *versionsJSON) set(key, val string) {
9393
vK = &v.Initrd
9494
case "rootfs":
9595
vK = &v.Rootfs
96-
case "data_img":
97-
vK = &v.DataImg
96+
case "data":
97+
vK = &v.Data
9898
}
9999

100100
if *vK != val {
@@ -116,7 +116,7 @@ type targetContext struct {
116116
versionsJSON *versionsJSON
117117
}
118118

119-
func newTarget(targetPath, kernelPath, initrdPath, rootfsPath, dataImgPath, versionsPath string) (*targetContext, error) {
119+
func newTarget(targetPath, kernelPath, initrdPath, rootfsPath, dataPath, versionsPath string) (*targetContext, error) {
120120
versionsJSON, err := newVersionsJSON(versionsPath)
121121
if err != nil {
122122
return nil, err
@@ -128,7 +128,7 @@ func newTarget(targetPath, kernelPath, initrdPath, rootfsPath, dataImgPath, vers
128128
{"kernel", kernelPath},
129129
{"initrd", initrdPath},
130130
{"rootfs", rootfsPath},
131-
{"data_img", dataImgPath},
131+
{"data", dataPath},
132132
},
133133

134134
versionsJSON: versionsJSON,
@@ -164,7 +164,7 @@ func (t *targetContext) copyOrCreate(src srcPath, g *errgroup.Group) {
164164
distPath := path.Join(t.targetPath, filepath.Base(src.p))
165165

166166
g.Go(func() error {
167-
if src.key == "data_img" {
167+
if src.key == "data" {
168168
if err := os.RemoveAll(distPath); err != nil {
169169
return err
170170
}
@@ -177,10 +177,10 @@ func (t *targetContext) copyOrCreate(src srcPath, g *errgroup.Group) {
177177
}
178178

179179
var versionsParams = map[string]string{
180-
"kernel": "",
181-
"initrd": "",
182-
"rootfs": "",
183-
"data_img": "",
180+
"kernel": "",
181+
"initrd": "",
182+
"rootfs": "",
183+
"data": "",
184184
}
185185

186186
func parseVersions() error {

0 commit comments

Comments
 (0)