fix(mount): cannot mount path with space in fstab (#55)

BlackHole1 · web-flow · commit f00dbf0547f2 · 2024-09-18T14:59:49.000+08:00
Signed-off-by: Kevin Cui &lt;bh@bugs.cc&gt;
diff --git a/pkg/vfkit/mount.go b/pkg/vfkit/mount.go
@@ -5,6 +5,7 @@ package vfkit
 
 import (
 	"fmt"
+	"strings"
 
 	"github.com/crc-org/vfkit/pkg/config"
 )
@@ -56,7 +57,9 @@ func (m *_mounts) toVFKit() (devices []config.VirtioDevice) {
 
 func (m *_mounts) toFSTAB() (result []string) {
 	for _, fs := range m.list {
-		fstab := fmt.Sprintf("%s %s virtiofs defaults 0 0", fs.tag, fs.shareDir)
+		// See: https://wiki.archlinux.org/title/Fstab#Filepath_spaces
+		dir := strings.ReplaceAll(fs.shareDir, " ", `\\\\040`)
+		fstab := fmt.Sprintf("%s %s virtiofs defaults 0 0", fs.tag, dir)
 		result = append(result, fstab)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ package vfkit`
`5`	`5`
`6`	`6`	`import (`
`7`	`7`	`"fmt"`
	`8`	`+ "strings"`
`8`	`9`
`9`	`10`	`"github.com/crc-org/vfkit/pkg/config"`
`10`	`11`	`)`
`@@ -56,7 +57,9 @@ func (m *_mounts) toVFKit() (devices []config.VirtioDevice) {`
`56`	`57`
`57`	`58`	`func (m *_mounts) toFSTAB() (result []string) {`
`58`	`59`	`for _, fs := range m.list {`
`59`		`- fstab := fmt.Sprintf("%s %s virtiofs defaults 0 0", fs.tag, fs.shareDir)`
	`60`	`+ // See: https://wiki.archlinux.org/title/Fstab#Filepath_spaces`
	`61`	+ dir := strings.ReplaceAll(fs.shareDir, " ", `\\\\040`)
	`62`	`+ fstab := fmt.Sprintf("%s %s virtiofs defaults 0 0", fs.tag, dir)`
`60`	`63`	`result = append(result, fstab)`
`61`	`64`	`}`
`62`	`65`