Description
- YTSage crashes with
argument of type 'NoneType' is not iterable when yt-dlp returns no stdout (handled by adding defensive checks in ytsage_gui_analysis.py).
- When the user selects
Brave as the cookie source, the program still uses the old config key browser_cookies instead of the current key cookie_browser. Result: only up to 720p formats are shown.
Steps to reproduce
- Install YTSage and keep default config.
- Open Settings → Cookies → Browser = Brave and enable “Remember”.
- Analyze any YouTube video that has 1080p+ formats.
- Only 720p and lower appear.
Expected behaviour
All available formats (including 1080p, 1440p, 4K) should be listed.
Actual behaviour
Only 720p and lower are shown.
Proposed fix
- Update
ytsage_gui_main_source.py to write the selected browser to the key cookie_browser instead of browser_cookies.
- Ensure
cookie_source is set to browser and cookie_remember is true so the setting persists.
- Add documentation in the settings dialog about Brave's cookie database lock issue (and suggest using Firefox or a manual
cookies.txt file as fallback).
- Keep the defensive
None checks that were already merged.
Additional notes
- If the user prefers Firefox instead of Brave, they can set
cookie_browser: firefox in the config or through the UI.
- Providing a manual
cookies.txt file works for any browser and avoids the lock problem.
Description
argument of type 'NoneType' is not iterablewhen yt-dlp returns no stdout (handled by adding defensive checks in ytsage_gui_analysis.py).Braveas the cookie source, the program still uses the old config keybrowser_cookiesinstead of the current keycookie_browser. Result: only up to 720p formats are shown.Steps to reproduce
Expected behaviour
All available formats (including 1080p, 1440p, 4K) should be listed.
Actual behaviour
Only 720p and lower are shown.
Proposed fix
ytsage_gui_main_source.pyto write the selected browser to the keycookie_browserinstead ofbrowser_cookies.cookie_sourceis set tobrowserandcookie_rememberis true so the setting persists.cookies.txtfile as fallback).Nonechecks that were already merged.Additional notes
cookie_browser: firefoxin the config or through the UI.cookies.txtfile works for any browser and avoids the lock problem.