Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Commit 44e80b5

Browse files
authored
fix(proofs/action): Fix interop action tests (#3210)
Fix action testing of the kona-interop program and re-enable that test in gh ci. fixes #3010, ethereum-optimism/optimism#18613
1 parent 3d78173 commit 44e80b5

File tree

2 files changed

+9
-23
lines changed

2 files changed

+9
-23
lines changed

.github/workflows/proof.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ jobs:
2020
kind: ["single", "interop"]
2121
parallel: [4]
2222
index: [0, 1, 2, 3] # Remember to update step 'Merge reports' as well.
23-
exclude:
24-
- kind: "interop" # See https://github.com/op-rs/kona/issues/3010
2523
steps:
2624
- name: Checkout sources
2725
uses: actions/checkout@v6
@@ -57,7 +55,7 @@ jobs:
5755
with:
5856
total: ${{ matrix.parallel }}
5957
index: ${{ matrix.index }}
60-
working-directory: ./tests/optimism/op-e2e/actions/proofs
58+
working-directory: ./tests/optimism/op-e2e/actions/${{ matrix.kind == 'single' && 'proofs' || 'interop' }}
6159

6260
- name: Build and Run Action Tests
6361
run: |

tests/justfile

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,10 @@ long-running-test FILTER="" OUTPUT_LOGS_DIR="":
184184
cd {{SOURCE}} && go test -count=1 -timeout 0 -v ./node/long-running $FILTER
185185

186186
# Run action tests for the single-chain client program on the native target
187-
action-tests-single test_name='Test_ProgramAction' *args='': action-tests-single-build (action-tests-single-run test_name args)
187+
action-tests-single test_name='Test_ProgramAction' *args='': action-tests-build (action-tests-single-run test_name args)
188188

189-
# Build action tests for the single-chain client program on the native target
190-
action-tests-single-build:
189+
# Build action tests for host program
190+
action-tests-build:
191191
#!/bin/bash
192192
echo "Building contract artifacts for the optimism"
193193
just unzip-contract-artifacts {{SOURCE}}/optimism/packages/contracts-bedrock
@@ -206,28 +206,16 @@ action-tests-single-run test_name='Test_ProgramAction' *args='':
206206
cd {{SOURCE}}/optimism/op-e2e/actions/proofs && GITHUB_ACTIONS=false gotestsum --format=short-verbose -- -count=1 -timeout 60m -run "{{test_name}}" {{args}}
207207

208208
# Run action tests for the interop client program on the native target
209-
action-tests-interop test_name='TestInteropFaultProofs' *args='':
210-
#!/bin/bash
211-
echo "Building contract artifacts for the optimism"
212-
just unzip-contract-artifacts {{SOURCE}}/optimism/packages/contracts-bedrock
213-
214-
echo "Building host program for the native target"
215-
just build-native --bin kona-host
216-
export KONA_HOST_PATH="{{justfile_directory()}}/target/debug/kona-host"
209+
action-tests-interop test_name='TestInteropFaultProofs' *args='': action-tests-build (action-tests-interop-run test_name args)
217210

211+
action-tests-interop-run test_name='TestInteropFaultProofs' *args='':
212+
#!/bin/bash
213+
export KONA_HOST_PATH="{{SOURCE}}/../target/debug/kona-host"
218214
# GitHub actions patch - do not print logs.
219215
# https://github.com/gotestyourself/gotestsum/blob/b4b13345fee56744d80016a20b760d3599c13504/testjson/format.go#L442-L444
220216
echo "Running action tests for the client program on the native target"
221217

222-
cd {{SOURCE}}/optimism/op-e2e/actions/interop && GITHUB_ACTIONS=false gotestsum --format=testname -- -run "{{test_name}}" {{args}} -count=1 ./...
223-
224-
action-tests-interop-build test_name='TestInteropFaultProofs' *args='':
225-
#!/bin/bash
226-
echo "Not implemented. See https://github.com/op-rs/kona/issues/3010"
227-
228-
action-tests-interop-run test_name='TestInteropFaultProofs' *args='':
229-
#!/bin/bash
230-
echo "Not implemented. See https://github.com/op-rs/kona/issues/3010"
218+
cd {{SOURCE}}/optimism/op-e2e/actions/interop && GITHUB_ACTIONS=false gotestsum --format=short-verbose -- -count=1 -timeout 60m -run "{{test_name}}" {{args}}
231219

232220
unzip-contract-artifacts DEST_DIR="":
233221
#!/bin/bash

0 commit comments

Comments
 (0)