-
Notifications
You must be signed in to change notification settings - Fork 217
Description
Priority
Undecided
OS type
N/A
Hardware type
N/A
Running nodes
N/A
Description
Issue
Small changes or omissions can have large impact on GenAIComps image sizes, but currently such changes can easily go in unnoticed in PR reviews. E.g. forgetting to specify that given Python module indirect dependencies should pull CPU version of PyTorch instead of Nvidia / CUDA one, can increase images size by 3.5 GiB.
Proposed solution
It would help if some automation could provide image size difference information to the PR, for the images that CI determines to be affected by the PR[1].
It would be preferable for size difference to be against latest version in DockerHub, but if that's too hard, a size difference against (e.g. hard-coded info of) image sizes of previous release could be an alternative.
[1] Because many things do not specify dependency versions, but just pull in the whatever is latest, rebuilding an image could cause image size change (or functional changes), without any change in OPEA repository content. This is a separate problem though.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status